-
Notifications
You must be signed in to change notification settings - Fork 8
merge v0.4.10 into master #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
699a850
b4816d4
45b0e98
00bfe6c
ce23e72
406415e
920ef4d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,7 @@ There are BREAKING CHANGES between v0.3.x and v0.4.x, make sure to read the [mig | |
| - [4. Debug Your Contract {#debug-contract}](#4-debug-your-contract-debug-contract) | ||
| - [5. Explore Built-in Scripts {#explore-scripts}](#5-explore-built-in-scripts-explore-scripts) | ||
| - [6. Tweak Devnet Config {#tweak-devnet-config}](#6-tweak-devnet-config-tweak-devnet-config) | ||
| - [7. Fork Mainnet/Testnet Into Your Devnet {#fork-devnet}](#7-fork-mainnettestnet-into-your-devnet-fork-devnet) | ||
| - [Config Setting](#config-setting) | ||
| - [List All Settings](#list-all-settings) | ||
| - [Set CKB version](#set-ckb-version) | ||
|
|
@@ -330,7 +331,7 @@ offckb system-scripts --output <output-file-path> | |
|
|
||
| ### 6. Tweak Devnet Config {#tweak-devnet-config} | ||
|
|
||
| By default, OffCKB use a fixed Devnet config. You can customize it, for example by modifying the default log level (`warn,ckb-script=debug`). | ||
| By default, OffCKB use a fixed Devnet config. You can customize it, for example by modifying the default log level (`info,ckb-script=debug`). | ||
|
|
||
| 1. Open the interactive Devnet config editor: | ||
|
|
||
|
|
@@ -414,7 +415,7 @@ On a forked devnet, `offckb system-scripts`, transfers, deploys and `offckb debu | |
| > [!CAUTION] | ||
| > CKB transactions carry no chain id, so a transaction built on a mainnet fork that spends copied mainnet cells is also valid on mainnet (CKB provides no replay protection). offckb's own flows only use dev keys and fork-mined cells, which cannot replay. Never sign transactions with real mainnet keys against a fork unless you intend to broadcast them yourself. | ||
|
|
||
| `offckb transfer` fails closed on a Mainnet fork: non-built-in keys require `--allow-mainnet-replay-risk`, and inputs copied from Mainnet are rejected even with that override. | ||
| `offckb transfer` fails closed on a Mainnet fork: non-built-in keys require `--allow-external-key-on-mainnet-fork`, and inputs copied from Mainnet are rejected even with that override. (`--allow-mainnet-replay-risk` from 0.4.9 remains as a deprecated alias.) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Document all guarded signing commands. The changelog says the replay guard also covers 🤖 Prompt for AI Agents |
||
|
|
||
| ## Config Setting | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct the grammar and terminology.
Use “OffCKB uses” instead of “OffCKB use”, and call
info,ckb-script=debuga log filter rather than a single log level.🤖 Prompt for AI Agents