Avoid .NET globalization crash in LLM benchmarks#5335
Merged
bradleyshep merged 9 commits intoJun 16, 2026
Conversation
clockwork-labs-bot
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
clockwork-labs-bot
changed the title
bfops
requested review from
bradleyshep
and removed request for
bfops,
cloutiertyler and
jdetter
bradleyshep
merged commit 23ab3f7
into
bradley/fix-validate-goldens-ci
29 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Sets
DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1only on the benchmark harness command that publishes generated C# modules. This keeps dotnet startup out of localized DateTime/TimeZoneInfo formatting on the CI runner, which was crashing before generated C# module publish could run.Stacked on #5324.
gh workflow run llm-benchmark-periodic.yml \ --repo ClockworkLabs/SpacetimeDB \ --ref bot/debug-llm-csharp-publish \ -f model_set=explicit \ -f models="openrouter:openai/gpt-5.4-mini" \ -f languages=rust,csharp,typescript \ -f modes=guidelines \ -f tasks=t_000_empty_reducers \ -f dry_run=trueAPI and ABI breaking changes
None.
Expected complexity level and risk
Testing
cargo fmt --allcargo check --manifest-path tools/xtask-llm-benchmark/Cargo.tomlruby -e 'require "yaml"; YAML.load_file(".github/workflows/llm-benchmark-periodic.yml"); YAML.load_file(".github/workflows/llm-benchmark-validate-goldens.yml")'\n- [x]git diff --check