commitlog: Add a test that triggers the panic when commit.write fails - #5829
Open
kim wants to merge 1 commit into
Open
commitlog: Add a test that triggers the panic when commit.write fails#5829kim wants to merge 1 commit into
commit.write fails#5829kim wants to merge 1 commit into
Conversation
Also adjust the commentary to explain why we're doing that, and include the size of the remaining buffer in the panic message. Also fix passing the write buffer size when resuming a segment.
kim
force-pushed
the
kim/commitlog/test-commit-write-panic
branch
from
August 28, 2026 07:38
bcb2673 to
afda5da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adjust the commentary to explain why we're doing that, and include the size of the remaining buffer in the panic message.
Also fix passing the write buffer size when resuming a segment.
Expected complexity level and risk
1
Testing
Add a test.