tests: Fixes deployment instances cleanup leak#468
Open
claudiubelu wants to merge 1 commit into
Open
Conversation
During test_replica_deployment_crud we delete the deployment for testing purposes. Because of that, self._cleanup_deployment won't have the deployment record needed to get the list of deployed instances to clean up. We can register the cleanup with the list of deployment instances known at that time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During
test_replica_deployment_crudwe delete the deployment for testing purposes. Because of that,self._cleanup_deploymentwon't have the deployment record needed to get the list of deployed instances to clean up.We can register the cleanup with the list of deployment instances known at that time.