Skip to content

fix broken ci tasks after removal of ruby - #363

Merged
neddp merged 1 commit into
cloudfoundry:masterfrom
dudejas:fix-broken-ci-tasks-after-ruby-removal
Sep 9, 2026
Merged

fix broken ci tasks after removal of ruby#363
neddp merged 1 commit into
cloudfoundry:masterfrom
dudejas:fix-broken-ci-tasks-after-ruby-removal

Conversation

@dudejas

@dudejas dudejas commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Fix BATS director deployment after bosh-deployment Go CPI default

Since bosh-deployment#528, openstack/cpi.yml installs openstack_cpi_golang by default. The use-golang-cpi.yml ops file was written to swap the Ruby job (openstack_cpi) for the Go one, but with Go now the default there is no openstack_cpi job left to replace — causing the interpolation to fail:


Error 'operation [0] in use-golang-cpi.yml failed':
Expected to find exactly one matching array item for path
'/instance_groups/name=bosh/jobs/name=openstack_cpi' but found 0

Changes:

  • Removed USE_GOLANG_CPI variable and the maybe_golang_cpi_ops_file conditional from ci/tasks/deploy-manual-networking.sh — the ops file is a no-op now that Go is the default
  • Removed the corresponding USE_GOLANG_CPI param from ci/tasks/deploy-manual-networking.yml

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a4ac28e2-8cae-425c-9df5-05ea7c7ea708

📥 Commits

Reviewing files that changed from the base of the PR and between efc59ed and 8b2894e.

📒 Files selected for processing (2)
  • ci/tasks/deploy-manual-networking.sh
  • ci/tasks/deploy-manual-networking.yml
💤 Files with no reviewable changes (2)
  • ci/tasks/deploy-manual-networking.yml
  • ci/tasks/deploy-manual-networking.sh

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The manual networking Concourse task no longer sets USE_GOLANG_CPI. The deployment script no longer defines the variable, builds the conditional Go CPI ops-file argument, or passes that argument to bosh-go int.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 8b289

The manual networking deployment path removes the obsolete Go CPI toggle and its conditional ops-file handling. No concrete merge-blocking impact is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided. The available context does not include an author explanation of the changes. Add a short description that states which obsolete CI settings were removed and why the changes fix the CI tasks.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the change as a fix for CI tasks after Ruby removal. The changes update CI deployment tasks by removing obsolete Go CPI configuration.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@neddp
neddp merged commit 84d280f into cloudfoundry:master Sep 9, 2026
2 checks passed
@dudejas
dudejas deleted the fix-broken-ci-tasks-after-ruby-removal branch September 9, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants