[v8][cherry-pick]: Fix CI client-creds integration tests#3798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR is cherry-pick of #3797
Fixed the CI client-creds integration tests
integration-tests-ci-client-credsto retry transient BOSH Lite staging failuresIsMinimumAPIVersionMet: when the current API version is empty (as in the selfcontained Kubernetes auth test, which sets up config manually without callingcf api),semver.Make("")was called and returned "Version string empty", causingcf appsto fail. Guard against emptycurrentby returning false (minimum not met, use fallback path) instead of erroring. The test failure was introduced by [v8] Use embedded process instances for "cf apps" summary #3725 (embedded process instances forcf appssummary), which added theIsMinimumAPIVersionMet(actor.Config.APIVersion(), ...)call but did not account for contexts where APIVersion is unset.Why Is This PR Valuable?
This helps to fix the CI checks.
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
Fairly urgent to fix the CI checks
Other Relevant Parties
Who else is affected by the change?