chore(deps): update cloudoperators/juno digest to f2f7fde - #1837
chore(deps): update cloudoperators/juno digest to f2f7fde#1837renovate[bot] wants to merge 1 commit into
Conversation
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the pinned reference for the shared Slack notification reusable workflow used across multiple GitHub Actions workflows.
Changes:
- Bump
cloudoperators/juno/.github/workflows/shared-slack-notification.yamlfromf0c9d08…tocf79a1f…in release notifications. - Bump the same reusable workflow reference in image build/push workflows (Supernova, Greenhouse, PR preview cleanup).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| .github/workflows/release.yaml | Updates the reusable Slack notification workflow commit SHA for success/failure notifications. |
| .github/workflows/build-push-supernova-image.yaml | Updates the reusable Slack notification workflow commit SHA for failure notification. |
| .github/workflows/build-push-greenhouse-pr-preview.yaml | Updates the reusable Slack notification workflow commit SHA for cleanup-failure notification. |
| .github/workflows/build-push-greenhouse-image.yaml | Updates the reusable Slack notification workflow commit SHA for failure notification. |
| if: needs.release.outputs.published == 'true' | ||
| needs: [release] # List the jobs that should complete successfully | ||
| uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@f0c9d08e2c9d7c348dd3f24e7ea72ac3db3a6993 # main | ||
| uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@cf79a1fa0104662588fba8f166e1e6b5c975eb0f # main |
| if: failure() | ||
| needs: [release] | ||
| uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@f0c9d08e2c9d7c348dd3f24e7ea72ac3db3a6993 # main | ||
| uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@cf79a1fa0104662588fba8f166e1e6b5c975eb0f # main |
| contents: read | ||
| needs: [build-and-push, vulnerability-scan] | ||
| uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@f0c9d08e2c9d7c348dd3f24e7ea72ac3db3a6993 # main | ||
| uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@cf79a1fa0104662588fba8f166e1e6b5c975eb0f # main |
| needs: [ cleanup ] | ||
| permissions: {} | ||
| uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@f0c9d08e2c9d7c348dd3f24e7ea72ac3db3a6993 # main | ||
| uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@cf79a1fa0104662588fba8f166e1e6b5c975eb0f # main |
| contents: read | ||
| needs: [build-and-push, vulnerability-scan] | ||
| uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@f0c9d08e2c9d7c348dd3f24e7ea72ac3db3a6993 # main | ||
| uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@cf79a1fa0104662588fba8f166e1e6b5c975eb0f # main |
d676bb0 to
d6fc19e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (3)
.github/workflows/release.yaml:79
- The inline comment
# mainis misleading when pinning to a specific commit SHA (it no longer reflects themainref, but a snapshot). Consider changing it to something like# pinned/# commit(optionally include the upstream tag/version) to avoid confusion during future audits and updates.
uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@3a9760d43222cfa4912d61b052b1f062a7bfc48d # main
.github/workflows/release.yaml:90
- The inline comment
# mainis misleading when pinning to a specific commit SHA (it no longer reflects themainref, but a snapshot). Consider changing it to something like# pinned/# commit(optionally include the upstream tag/version) to avoid confusion during future audits and updates.
uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@3a9760d43222cfa4912d61b052b1f062a7bfc48d # main
.github/workflows/build-push-supernova-image.yaml:204
- The same reusable workflow SHA is duplicated across multiple workflow files in this PR, which makes future bumps easy to miss and harder to review. Consider introducing a local wrapper reusable workflow (e.g.,
.github/workflows/slack-notify.yaml) that internally calls the upstreamcloudoperators/junoworkflow at the pinned SHA; then have all callers reference the local wrapper so the pin is updated in one place.
uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@3a9760d43222cfa4912d61b052b1f062a7bfc48d # main
d6fc19e to
5985c01
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (3)
.github/workflows/release.yaml:1
- The same reusable workflow revision is duplicated (even within this file) and also repeated across multiple workflow files in this PR. This increases the chance of version drift and makes future bumps more error-prone. Consider centralizing the reference (e.g., create a local reusable workflow wrapper in this repo that pins
cloudoperators/juno/...@<sha>once, then have workflows call the local wrapper), or use YAML anchors/aliases within a file to avoid repeating the sameuses:string in multiple jobs.
name: Release
.github/workflows/release.yaml:93
- The same reusable workflow revision is duplicated (even within this file) and also repeated across multiple workflow files in this PR. This increases the chance of version drift and makes future bumps more error-prone. Consider centralizing the reference (e.g., create a local reusable workflow wrapper in this repo that pins
cloudoperators/juno/...@<sha>once, then have workflows call the local wrapper), or use YAML anchors/aliases within a file to avoid repeating the sameuses:string in multiple jobs.
uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@5ba36b2779a7a4af75cdfc20cfc5567865020fac # main
with:
title: "🚨 JUNO Packages Release Failed 🚨"
body: "An error occurred while releasing JUNO Packages for the branch ${{ github.head_ref || github.ref_name }}. Please check the logs for more information. <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|Check the logs>"
.github/workflows/build-push-supernova-image.yaml:204
- The inline comment
# mainis misleading because the workflow is pinned to a specific commit SHA, not themainref. Updating/removing this comment (and the same comment in other workflow files) would avoid confusion; for example, note the short SHA or a release tag if one exists.
uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@5ba36b2779a7a4af75cdfc20cfc5567865020fac # main
5985c01 to
a3ec7f0
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (3)
.github/workflows/release.yaml:79
- The pinned reusable-workflow SHA is duplicated across multiple workflows/files, which increases the chance of inconsistent upgrades in the future. Consider introducing a local wrapper reusable workflow (e.g.,
uses: ./.github/workflows/shared-slack-notification-wrapper.yaml) that internally callscloudoperators/juno/...@<sha>so future SHA bumps happen in one place.
uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@7aa14ad04fba12a67a33e8cbbad5f5ecb9422e1b # main
.github/workflows/release.yaml:90
- The pinned reusable-workflow SHA is duplicated across multiple workflows/files, which increases the chance of inconsistent upgrades in the future. Consider introducing a local wrapper reusable workflow (e.g.,
uses: ./.github/workflows/shared-slack-notification-wrapper.yaml) that internally callscloudoperators/juno/...@<sha>so future SHA bumps happen in one place.
uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@7aa14ad04fba12a67a33e8cbbad5f5ecb9422e1b # main
.github/workflows/release.yaml:79
- The inline comment
# mainis potentially misleading since the workflow is pinned to a specific commit SHA (not the movingmainref). Suggest updating the comment to something unambiguous (e.g.,# pinnedor# juno <version/tag/commit>), or remove it to avoid implying it tracks the branch.
uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@7aa14ad04fba12a67a33e8cbbad5f5ecb9422e1b # main
a3ec7f0 to
8c789ff
Compare
8c789ff to
0d64f6e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
.github/workflows/release.yaml:79
- The inline comment
# mainis misleading when the workflow is pinned to a specific commit SHA (it may no longer reflect the currentmain). Consider removing the comment or replacing it with a versioned note (e.g., the intended upstream release/tag or a short reason for the bump) to avoid confusion during future audits.
uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@f2f7fde7ac0c3f351c179d54a22948d69872ef0f # main
.github/workflows/release.yaml:90
- The inline comment
# mainis misleading when the workflow is pinned to a specific commit SHA (it may no longer reflect the currentmain). Consider removing the comment or replacing it with a versioned note (e.g., the intended upstream release/tag or a short reason for the bump) to avoid confusion during future audits.
uses: cloudoperators/juno/.github/workflows/shared-slack-notification.yaml@f2f7fde7ac0c3f351c179d54a22948d69872ef0f # main
This PR contains the following updates:
f0c9d08→f2f7fdeConfiguration
📅 Schedule: (in timezone Europe/Berlin)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.