chore: Add visual regression testing#4509
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4509 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 948 948
Lines 30495 30507 +12
Branches 11154 11164 +10
=======================================
+ Hits 29755 29767 +12
+ Misses 733 693 -40
- Partials 7 47 +40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
b594908 to
4ef11e8
Compare
4ef11e8 to
735b397
Compare
|
|
||
| const testDefinitionsPackageJson = generatePackageJson(path.join(workspace.targetPath, 'test-definitions'), { | ||
| name: '@cloudscape-design/test-definitions', | ||
| exports: { |
There was a problem hiding this comment.
Needed for the internal tests to consume the test definitions, which are going to live in this package.
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20 |
There was a problem hiding this comment.
Updated to 24 (current LTS), in both deploy.yml and visual-regression.yml, which are the only files in this repo that use this parameter.
Description
Issue:
D417180663How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.