Skip to content

added open telementry#376

Open
raphael-goetz wants to merge 3 commits into
mainfrom
#353-open-telementry
Open

added open telementry#376
raphael-goetz wants to merge 3 commits into
mainfrom
#353-open-telementry

Conversation

@raphael-goetz

Copy link
Copy Markdown
Member

Resolves: #353

Copilot AI review requested due to automatic review settings July 6, 2026 13:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/aquila/-/pipelines/2655731025

Status: Passed
Duration: 1 minutes

Job summaries

docs:preview

Documentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/15202367521/artifacts/out/index.html

Comment thread src/telemetry/mod.rs

errors::enable_backtraces();
let resource = Resource::builder()
.with_service_name(env!("CARGO_PKG_NAME"))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this env variable come from? I'm also not sure if this should be part of the configuration, so you can override the service name if needed.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indirectly set by the field name inside of the Cargo.toml => in this case its aquila

Comment thread src/telemetry/mod.rs
let resource = Resource::builder()
.with_service_name(env!("CARGO_PKG_NAME"))
.with_attributes([
KeyValue::new("service.version", env!("CARGO_PKG_VERSION")),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this env variable come from? Does this mean that we need to have the correct version number in the Cargo.toml before the build? (Which is the source of our caching problem)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here applies the same logic as with name

Comment thread aquila.yml
# OTLP export for logs, traces, and the deliberately small metric set.
telemetry:
enabled: false
endpoint: http://localhost:4317

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we separate this into three settings? (Logs, Metrics, Traces)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open Telemetry Support

3 participants