feat(#5476): Add configuration property to allow the selection of the mismatch strategy to use for status update events#5483
Merged
Conversation
SteKoe
requested changes
Jul 3, 2026
SteKoe
left a comment
SteKoe
left a comment
Contributor
There was a problem hiding this comment.
Hi, thanks for your PR!
We just reviewed it and have some change requests. Most importantly, we agreed on the default value to be STATUS_ONLY to revert the breaking change introduced in 4.1.1.
| * Strategy to determinate if two {@link StatusInfo} instances are different or | ||
| * not. | ||
| */ | ||
| public enum StatusInfoMismatchStrategy { |
Contributor
There was a problem hiding this comment.
Rename to StatusChangeDetectionStrategy.
| * {@link AdminServerProperties.MonitorProperties#DEFAULT_STATUS_MISMATCH_STRATEGY} | ||
| * unless a different value is specified. | ||
| */ | ||
| private StatusInfoMismatchStrategy statusMismatchStrategy = DEFAULT_STATUS_MISMATCH_STRATEGY; |
Contributor
There was a problem hiding this comment.
Rename this to statusChangeDetectionStrategy, too, please.
…tion of the mismatch strategy to use for status update events
Contributor
Author
|
@SteKoe all points apart #5483 (comment) have been addressed. Please review this once more. |
cdprete
force-pushed
the
feat/5476
branch
2 times, most recently
from
366f029 to
9e6af67
Compare
SteKoe
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5476.
Introduced the
spring.boot.admin.monitor.status-mismatch-strategyconfiguration property to allow the selection of the mismatch strategy to use for status update events.FULL) will resolve toequalsas per4.1.1implementation (backwards compatibility)STATUS_ONLYvalue allows to revert the comparison/mismatch behaviour as per version <=4.1.0by checking only the status codeBiPredicate