feat: neo4j EXTENDS/IMPLEMENTS inheritance edges#41
Open
rahlk wants to merge 1 commit into
Open
Conversation
…hips Resolves each type's heritage signatures (base_classes/implements_types) through idBySig to can:// ids in the v2 emitter, dropping unresolved external/library supertypes rather than nulling them. Exposes the result as extends_ids/implements_ids on the V2 type node (JSON props unchanged) and projects them as EXTENDS/IMPLEMENTS relationships in Neo4j via the previously-dead RowBuilder.edgeToSymbol deferred gate, which was also re-pointed at the correct CanNode/id addressing (it had been hardcoded to a Symbol/signature pair no node in the v2 schema actually carries). Adds a first-party class hierarchy fixture to dataflow-app and extends both the schema conformance test and the issue #27 Neo4j<->JSON parity gate (the latter now also has an exhaustive total-edge accounting test).
rahlk
force-pushed
the
feat/issue-33-neo4j-inheritance-edges
branch
from
f9502b2 to
bdd1aed
Compare
rahlk
force-pushed
the
chore/issue-32-formalize-reaching-defs
branch
from
2a32e42 to
f0d78ce
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33. Part of epic #26 (contract-correctness cluster).
Stacked PR 7 of 7 — base:
chore/issue-32-formalize-reaching-defs; review this PR's diff in isolation. Merge the stack bottom-up intofeat/issue-2-program-graphs.Verified: full suite 99 pass / 0 fail, typecheck clean, schema.neo4j.json in lockstep. Reviewed (task-scoped + final whole-branch review: READY TO MERGE).