chore: escape NUL key separators as \0 to restore text diffs#49
Open
rahlk wants to merge 1 commit into
Open
Conversation
src/build/neo4j/rows.ts and src/schema/v2/dataflow.ts used raw 0x00 bytes as template-literal key separators (Map keys / sort-comparator keys), which made git treat both files as binary and hid contract- adjacent edits from review. Replace each raw NUL with the `\0` escape sequence — at runtime "\0" is still U+0000, so every key built from it is byte-identical; only the on-disk representation changes, from binary to plain text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44. Epic #26 follow-up.
Stacked on
fix/issue-43-neo4j-application-version(on top of the compliance cluster). Review this PR's diff in isolation; merge the follow-up stack bottom-up after the cluster. (Note: renders as a binary diff on GitHub because the parent blob still had NUL — verified byte-for-byte viaod -cas pure NUL→\0; future diffs are text.)Verified: 104 tests / 0 fail, typecheck clean, schema.neo4j.json lockstep; task-scoped review + final whole-branch review (READY TO MERGE).