Skip to content

chore: update golangci action #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xcoulon merged 1 commit into from
Aug 6, 2026
Merged

chore: update golangci action #520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/ci-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ jobs:
- name: Lint
uses: golangci/golangci-lint-action@v9
with:
version: v2.1.6
skip-pkg-cache: true
skip-build-cache: true
version: v2.12.2

@coderabbitai coderabbitai Bot Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

rg -n -C 3 'golangci|v2\.[0-9]+\.[0-9]+' .github/workflows .golangci.yml

Repository: codeready-toolchain/api

Length of output: 1659

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- verify-dependencies.yml ---'
cat -n .github/workflows/verify-dependencies.yml
printf '%s\n' '--- ci-build.yml ---'
cat -n .github/workflows/ci-build.yml
printf '%s\n' '--- lint configuration references ---'
rg -n -C 4 'golangci|golangci-lint|\.golangci|lint' .github .golangci.yml Makefile* 2>/dev/null || true

Repository: codeready-toolchain/api

Length of output: 4400

🏁 Script executed:

#!/bin/bash
set -euo pipefail

python3 - <<'PY'
from pathlib import Path
import re

for path in [Path(".github/workflows/verify-dependencies.yml"),
             Path(".github/workflows/ci-build.yml")]:
    text = path.read_text()
    print(f"--- {path} ---")
    for i, line in enumerate(text.splitlines(), 1):
        if re.search(r"golangci|lint|verify|\.golangci", line, re.I):
            print(f"{i}: {line}")
PY

printf '%s\n' '--- workflow triggers and job commands ---'
sed -n '1,120p' .github/workflows/verify-dependencies.yml
sed -n '1,100p' .github/workflows/ci-build.yml

Repository: codeready-toolchain/api

Length of output: 1890

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- verify-replace-run definition and references ---'
rg -n -C 8 'verify-replace-run|golangci-lint|\.golangci\.yml' --glob 'Makefile*' --glob '*.mk' --glob '*.yml' --glob '*.yaml' --glob '*.sh' .

Repository: codeready-toolchain/api

Length of output: 1582

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- make composition ---'
sed -n '1,180p' Makefile
printf '%s\n' '--- verify-replace.sh ---'
cat -n scripts/verify-replace.sh
printf '%s\n' '--- lint target dependencies ---'
rg -n -C 5 'lint-go-code|lint-yaml|lint:' Makefile make scripts .github 2>/dev/null || true

Repository: codeready-toolchain/api

Length of output: 6113

🏁 Script executed on selected repositories:

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- verification targets and GolangCI-Lint usage ---'
rg -n -C 6 '(^|[[:space:]])(pre-verify|verify-dependencies|lint-go-code|lint:)|golangci-lint|\.golangci\.yml' \
  Makefile make scripts .github 2>/dev/null || true

Repositories: codeready-toolchain/toolchain-common, codeready-toolchain/host-operator, codeready-toolchain/toolchain-e2e

Length of output: 13898

Update the GolangCI-Lint version in verify-dependencies.yml to v2.12.2. verify-replace-run runs dependent repositories’ verify-dependencies targets, which invoke lint-go-code and use this installed binary.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci-build.yml at line 28, Update the GolangCI-Lint version
used by the CI dependency verification workflow to v2.12.2, ensuring the
configuration consumed by verify-dependencies and its verify-replace-run flow
installs that exact version for lint-go-code.

args: --config=./.golangci.yml --verbose


Loading