Fix regression preventing users from emptying their profile text#2100
Merged
Conversation
Oaphi
force-pushed
the
0valt/2099/empty-profile-fix
branch
2 times, most recently
from
July 16, 2026 23:16
af2784f to
d68a8ba
Compare
Oaphi
force-pushed
the
0valt/2099/empty-profile-fix
branch
from
July 16, 2026 23:24
d68a8ba to
592359f
Compare
trichoplax
requested changes
Jul 19, 2026
trichoplax
left a comment
trichoplax
left a comment
Contributor
There was a problem hiding this comment.
I think there's an edge case where this will still fail (leaving the profile text rendered as if there were no change, while leaving the profile field in the "Edit" tab still appearing empty to the user). I've suggested an extra test to catch this.
Oaphi
force-pushed
the
0valt/2099/empty-profile-fix
branch
from
July 19, 2026 15:21
826259e to
46419fd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
trichoplax
approved these changes
Jul 19, 2026
trichoplax
left a comment
trichoplax
left a comment
Contributor
There was a problem hiding this comment.
Looks good, and saving the profile works now, for empty, whitespace, and text.
cellio
approved these changes
Jul 23, 2026
cellio
left a comment
cellio
left a comment
Member
There was a problem hiding this comment.
Tested and confirmed fix. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2099