chore(deps): upgrade comark-docs layer - #435
Conversation
◈ PR Lens
Architecture 1 component touched across 2 lanes. Data flow No data-flow sequence changed in this PR. View
Tip Click the link under each diagram to open it on a canvas you can zoom, pan and step through. 🪧 More tips
Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe workspace catalog updates ChangesDependency catalog updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to No merge-blocking issue is identified in the dependency catalog update. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
comark
@comark/angular
@comark/ansi
@comark/html
@comark/nuxt
@comark/react
@comark/svelte
@comark/vue
commit: |
comark-docs layer
What
Bumps the
comark-docslayer fromdd90fb10to05a64d32, which brings thenuxt-agent-discoverymigration (comarkdown/comark-docs#40), thecomark-content0.4.1 / comark 0.7 upgrade (comarkdown/comark-docs#45) and theuseRoutefix (comarkdown/comark-docs#46). Runspnpm dedupeon top, aligns the catalog on nuxt 4.5.2 and@nuxt/kit4.5.2, and drops the@nuxt/contentcatalog entry nothing referenced since #310.Why
The pinned layer was still on the hand-rolled markdown negotiation and a pkg.pr.new build of
comark-content. Nothing on this side uses the deprecatedcomarkDocs.skills.dir, so no config change was needed.Dedupe exposed a latent issue:
@nuxt/kit4.4.8 imports@nuxt/schematypes without declaring it, so it resolves through pnpm's hoisted store. Once the layer pulled@nuxt/schema4.5.2 in, the hoisted copy flipped and@comark/nuxtfailed to typecheck against twoNuxttypes. Moving the catalog to 4.5.2 leaves a single@nuxt/schemain the tree. The only remaining@nuxt/kit4.4.8 is the one pinned by the published@comark/nuxt0.7.0 that the layer depends on.The first push of this branch rendered every docs page as a 500 on Vercel. Same mechanism, other package: the layer's
app.vueimporteduseRoutefromvue-routerdirectly, and with nuxt 4.5.2 onvue-router5.3.1 while other workspace packages still pull 5.1.0, a fresh install hoists the 5.1.0 copy for that import. Two copies in the bundle means two injection symbols, souseRoute()returnedundefinedon SSR. Local builds were fine because this machine's install happens to hoist 5.3.1. comarkdown/comark-docs#46 moves the layer onto the Nuxt auto-import, which reads the route from the Nuxt app and cannot hit this.Workspace typecheck and tests pass, and
NITRO_PRESET=vercel pnpm buildindocscompletes with the layer's newopenapi.jsonroute.Summary by CodeRabbit
Maintenance
User Impact