Skip to content

chore(deps): upgrade comark-docs layer - #435

Merged
benjamincanac merged 3 commits into
mainfrom
chore/upgrade-comark-docs
Sep 15, 2026
Merged

benjamincanac merged 3 commits into
mainfrom
chore/upgrade-comark-docs

Conversation

@benjamincanac

@benjamincanac benjamincanac commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

What

Bumps the comark-docs layer from dd90fb10 to 05a64d32, which brings the nuxt-agent-discovery migration (comarkdown/comark-docs#40), the comark-content 0.4.1 / comark 0.7 upgrade (comarkdown/comark-docs#45) and the useRoute fix (comarkdown/comark-docs#46). Runs pnpm dedupe on top, aligns the catalog on nuxt 4.5.2 and @nuxt/kit 4.5.2, and drops the @nuxt/content catalog entry nothing referenced since #310.

Why

The pinned layer was still on the hand-rolled markdown negotiation and a pkg.pr.new build of comark-content. Nothing on this side uses the deprecated comarkDocs.skills.dir, so no config change was needed.

Dedupe exposed a latent issue: @nuxt/kit 4.4.8 imports @nuxt/schema types without declaring it, so it resolves through pnpm's hoisted store. Once the layer pulled @nuxt/schema 4.5.2 in, the hoisted copy flipped and @comark/nuxt failed to typecheck against two Nuxt types. Moving the catalog to 4.5.2 leaves a single @nuxt/schema in the tree. The only remaining @nuxt/kit 4.4.8 is the one pinned by the published @comark/nuxt 0.7.0 that the layer depends on.

The first push of this branch rendered every docs page as a 500 on Vercel. Same mechanism, other package: the layer's app.vue imported useRoute from vue-router directly, and with nuxt 4.5.2 on vue-router 5.3.1 while other workspace packages still pull 5.1.0, a fresh install hoists the 5.1.0 copy for that import. Two copies in the bundle means two injection symbols, so useRoute() returned undefined on SSR. Local builds were fine because this machine's install happens to hoist 5.3.1. comarkdown/comark-docs#46 moves the layer onto the Nuxt auto-import, which reads the route from the Nuxt app and cannot hit this.

Workspace typecheck and tests pass, and NITRO_PRESET=vercel pnpm build in docs completes with the layer's new openapi.json route.

Summary by CodeRabbit

  • Maintenance

    • Updated the application framework components to newer versions.
    • Refreshed package management configuration to keep project tooling aligned with current release requirements.
    • Adjusted package version acceptance rules to support an additional compatible release.
  • User Impact

    • No changes to publicly exposed features or functionality are expected from this update.

@coldtea-pr-lens

coldtea-pr-lens Bot commented Sep 15, 2026

Copy link
Copy Markdown

◈ PR Lens

🟢 +0 new · 🟠 ~1 changed · 🔴 -0 removed · 0 flows · 2 files · commit 649bce0


Architecture

Architecture diagram for comarkdown/comark at 649bce0

1 component touched across 2 lanes.

Open the interactive canvas


Data flow

No data-flow sequence changed in this PR.


View

  • Architecture lens
  • Data flow lens
  • Expand every detail

Tip

Click the link under each diagram to open it on a canvas you can zoom, pan and step through.

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists.
  • Untick Architecture lens or Data flow lens under View to hide a diagram, or tick Expand every detail to open every section. The comment redraws in a few seconds.
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change.
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time.
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time.
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs on every push.
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works.
  • Push a commit and the comment redraws for the new head. A slow older run never overwrites a newer one.
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion.

Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
comark Ready Ready Preview Sep 15, 2026 12:32pm UTC
comark-binding Ready Ready Preview Sep 15, 2026 12:32pm UTC
comark-json-render Ready Ready Preview Sep 15, 2026 12:32pm UTC
comark-nextjs Ready Ready Preview Sep 15, 2026 12:32pm UTC
comark-nuxt Ready Ready Preview Sep 15, 2026 12:32pm UTC
comark-svelte Ready Ready Preview Sep 15, 2026 12:32pm UTC
comark-sveltekit Ready Ready Preview Sep 15, 2026 12:32pm UTC
comark-twoslash Ready Ready Preview Sep 15, 2026 12:32pm UTC
comark-vue Ready Ready Preview Sep 15, 2026 12:32pm UTC

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 63b8cab5-0dec-4028-8599-d1a764a95a0e

📥 Commits

Reviewing files that changed from the base of the PR and between 2bc7758 and 649bce0.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml
💤 Files with no reviewable changes (1)
  • pnpm-workspace.yaml

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The workspace catalog updates @nuxt/kit and nuxt to version 4.5.2, removes the @nuxt/content catalog entry, and adds 0.4.1 to the comark-content exclusion.

Changes

Dependency catalog updates

Layer / File(s) Summary
Nuxt and release-age catalog updates
pnpm-workspace.yaml
The catalog updates @nuxt/kit from 4.4.8 to 4.5.2, updates nuxt from ^4.4.8 to ^4.5.2, removes the @nuxt/content entry, and adds 0.4.1 to the comark-content exclusion.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 649bc

No merge-blocking issue is identified in the dependency catalog update.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies the primary change: upgrading the comark-docs layer and its dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/upgrade-comark-docs

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

comark

npm i https://pkg.pr.new/comark@435

@comark/angular

npm i https://pkg.pr.new/@comark/angular@435

@comark/ansi

npm i https://pkg.pr.new/@comark/ansi@435

@comark/html

npm i https://pkg.pr.new/@comark/html@435

@comark/nuxt

npm i https://pkg.pr.new/@comark/nuxt@435

@comark/react

npm i https://pkg.pr.new/@comark/react@435

@comark/svelte

npm i https://pkg.pr.new/@comark/svelte@435

@comark/vue

npm i https://pkg.pr.new/@comark/vue@435

commit: 649bce0

@benjamincanac benjamincanac changed the title chore(deps): upgrade comark-docs layer and dedupe lockfile chore(deps): upgrade comark-docs layer Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants