Skip to content

fix: empty toast group pads a 20px gap above the widget header - #516

Merged
omridevk merged 1 commit into
mainfrom
fix/toast-group-empty-gap
Aug 15, 2026
Merged

fix: empty toast group pads a 20px gap above the widget header#516
omridevk merged 1 commit into
mainfrom
fix/toast-group-empty-gap

Conversation

@omridevk

Copy link
Copy Markdown
Contributor

The notifications region added in #485 reserves a padded strip above the header even with zero toasts.

Root cause: zag sets inline display: flex on the toast group, and inline style beats the empty:hidden class rule — so the empty group always renders, and its p-2.5 is the visible 20px gap.

Fix: the padding is conditional (empty:p-0) instead of fighting the inline display. The dead empty:hidden is removed.

Test: new browser test pins the behaviour — the Notifications region is not visible while empty, becomes visible with a notice, and collapses again after dismissal. RED before the fix (failed at the first not.toBeVisible), 144/144 after.

🤖 Generated with Claude Code

zag inlines display:flex on the toast group, so empty:hidden never
applied; the group's p-2.5 rendered as a standing 20px strip. The
padding is now conditional (empty:p-0) instead of fighting the inline
display.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@omridevk, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 626b7c48-fb01-4cf9-8487-ead8c40479f6

📥 Commits

Reviewing files that changed from the base of the PR and between c6330c2 and 895f978.

📒 Files selected for processing (3)
  • .changeset/toast-group-empty-gap.md
  • apps/conciv/src/shell/notices.tsx
  • apps/conciv/test/notices.browser.test.tsx

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the empty toast group’s padding so it no longer creates a gap above the widget header.

Changes:

  • Applies zero padding when the toast group is empty.
  • Adds browser coverage for showing and collapsing the notifications region.
  • Adds a patch changeset.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
apps/conciv/src/shell/notices.tsx Conditionally removes empty-group padding.
apps/conciv/test/notices.browser.test.tsx Tests the notification region lifecycle.
.changeset/toast-group-empty-gap.md Documents the patch release.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@omridevk
omridevk merged commit 70614e8 into main Aug 15, 2026
27 checks passed
@omridevk
omridevk deleted the fix/toast-group-empty-gap branch August 15, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants