fix: empty toast group pads a 20px gap above the widget header - #516
Conversation
zag inlines display:flex on the toast group, so empty:hidden never applied; the group's p-2.5 rendered as a standing 20px strip. The padding is now conditional (empty:p-0) instead of fighting the inline display. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 3 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
There was a problem hiding this comment.
Pull request overview
Removes the empty toast group’s padding so it no longer creates a gap above the widget header.
Changes:
- Applies zero padding when the toast group is empty.
- Adds browser coverage for showing and collapsing the notifications region.
- Adds a patch changeset.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apps/conciv/src/shell/notices.tsx |
Conditionally removes empty-group padding. |
apps/conciv/test/notices.browser.test.tsx |
Tests the notification region lifecycle. |
.changeset/toast-group-empty-gap.md |
Documents the patch release. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The notifications region added in #485 reserves a padded strip above the header even with zero toasts.
Root cause: zag sets inline
display: flexon the toast group, and inline style beats theempty:hiddenclass rule — so the empty group always renders, and itsp-2.5is the visible 20px gap.Fix: the padding is conditional (
empty:p-0) instead of fighting the inline display. The deadempty:hiddenis removed.Test: new browser test pins the behaviour — the Notifications region is not visible while empty, becomes visible with a notice, and collapses again after dismissal. RED before the fix (failed at the first
not.toBeVisible), 144/144 after.🤖 Generated with Claude Code