Change requests initial documentation for beta - #699
Conversation
Deploying configcat-docs with
|
| Latest commit: |
35cd63d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dc57e4e9.docs-xmy.pages.dev |
| Branch Preview URL: | https://changerequests.docs-xmy.pages.dev |
adams85
left a comment
There was a problem hiding this comment.
Most of these findings are suggestions. I request changes only where the PR goes against our UX guidelines or doesn't use the exact texts of the UI.
adams85
left a comment
There was a problem hiding this comment.
Most of these findings are suggestions. I request changes only where the PR goes against our UX guidelines or doesn't use the exact texts of the UI.
Co-authored-by: adams85 <31276480+adams85@users.noreply.github.com>
There was a problem hiding this comment.
The Validate Document check reports a bunch of errors: https://github.com/configcat/docs/actions/runs/31702205261/job/94453827912?pr=699
Please address them by following the screenshot guide's instructions on file naming conventions:
Use the following file name convention:
{name}_{pixel density}dpi.{extension}. For example:configcat-dashboard_192dpi.png.
There was a problem hiding this comment.
Another problem: images don't seem to be optimized. For example, conflict.png is ~600kB now, but it would be ~100kB if it were run through https://tinypng.com/.
adams85
left a comment
There was a problem hiding this comment.
All looks good now, thanks!
Describe the purpose of your pull request
Related issues (only if applicable)
How to test? (only if applicable)
Requirement checklist