Skip to content

fix(graphile-scoped-introspection): ESM tsconfig module es2022 / moduleResolution bundler - #1839

Merged
pyramation merged 1 commit into
mainfrom
fix/scoped-introspection-esm-tsconfig
Sep 17, 2026
Merged

pyramation merged 1 commit into
mainfrom
fix/scoped-introspection-esm-tsconfig

Conversation

@pyramation

Copy link
Copy Markdown
Contributor

Summary

pnpm build on main fails at graphile/graphile-scoped-introspection:

tsconfig.esm.json(5,15): error TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResolution' is set to 'NodeNext'.

The package landed (#1838) after #1834 branched, with the old-style ESM config (module: ESNext, no moduleResolution), so it inherits moduleResolution: nodenext from the root tsconfig and tsc rejects the pair. This aligns it with every other tsconfig.esm.json in the repo:

-    "module": "ESNext"
+    "module": "es2022",
+    "moduleResolution": "bundler"

Scanned all tsconfigs on main — this was the only one out of convention. Full pnpm build passes locally with this change.

Link to Devin session: https://app.devin.ai/sessions/d34558e831ad4bbf986f64cc4bd509bd
Open in Devin Desktop: https://app.devin.ai/desktop/session/d34558e831ad4bbf986f64cc4bd509bd?variant=devin
Requested by: @pyramation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@tenki-reviewer

tenki-reviewer Bot commented Sep 17, 2026

Copy link
Copy Markdown

Review complete. No issues found — approved ✅.


This PR makes a small, low-risk TypeScript configuration standardization to the graphile-scoped-introspection package's ESM build. It changes module to es2022 and explicitly declares moduleResolution: bundler, aligning the package with the established ESM config pattern used elsewhere in the monorepo (e.g. pgpm/core and sdk/constructive-react). No source code, runtime behavior, or public API is affected.

Files Change
graphile/graphile-scoped-introspection/tsconfig.esm.json Aligns ESM module settings (es2022 + bundler resolution) with the repo's other packages.

Reviewed commit: 20b36fc

@pyramation
pyramation merged commit b45c6bf into main Sep 17, 2026
21 checks passed
@pyramation
pyramation deleted the fix/scoped-introspection-esm-tsconfig branch September 17, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant