feat(errors): register IDENTIFIER_CONFLICT, INVITE_ACCOUNT_EXISTS_UNVERIFIED, ALREADY_AUTHENTICATED_USE_LINK - #1847
Merged
Conversation
…ERIFIED, ALREADY_AUTHENTICATED_USE_LINK Codes raised by constructive-db#3806 (provisioning identifier resolution, invitee pending/accept lane, signed-in sign-up guard). Added to the audit inventory and regenerated registry.generated.ts; curated copy + 409 in registry.ts.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Review complete. No blocking issues — approved ✅; 2 nitpicks below. 🧹 Nitpicks (2) — 🟢 2 low
The PR extends the error registry with three curated definitions that override generated entries:
Reviewed commit: 3b72fcf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registers the three public error codes introduced by constructive-io/constructive-db#3806 so they resolve to user-facing copy and an HTTP status instead of falling through as unknown codes.
IDENTIFIER_CONFLICTprovision_<scope>_userwhenemailandphoneresolve to different usersINVITE_ACCOUNT_EXISTS_UNVERIFIEDALREADY_AUTHENTICATED_USE_LINKsign_up/sign_up_smscalled by an already-signed-in callerscripts/db-error-inventory.json: three entries added by hand rather than a full re-audit — a freshaudit-db-errors.pyrun against constructive-dbmainwould also drop theSTORAGE_*codes (they only exist on the unmergedfeat/storage-processing-lifecyclebranch) and failstorage-lifecycle.test.ts.src/generated/registry.generated.ts: regenerated from the inventory viagenerate-registry.py.src/registry.ts: curated overrides with real copy (generated heuristic gaveIDENTIFIER_CONFLICT/INVITE_ACCOUNT_EXISTS_UNVERIFIEDa 400).Link to Devin session: https://app.devin.ai/sessions/bb95227949054e6689dc66c815dbb738
Open in Devin Desktop: https://app.devin.ai/desktop/session/bb95227949054e6689dc66c815dbb738?variant=devin
Requested by: @pyramation