Skip to content

chore(repo): updating pnpm to v12 - #513

Merged
Charles Hudson (phobetron) merged 1 commit into
mainfrom
update-pnpm
Sep 21, 2026
Merged

Charles Hudson (phobetron) merged 1 commit into
mainfrom
update-pnpm

Conversation

@phobetron

Copy link
Copy Markdown
Collaborator

No description provided.

@bito-code-review

bito-code-review Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Code Review Agent Run #5b565d

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: cafb0de..cafb0de
    • implementations/react-native-sdk/pnpm-workspace.yaml
    • package.json
  • Files skipped - 1
    • pnpm-lock.yaml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers an incremental AI Review.

  • /review full - Manually triggers a full AI Review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at jared.jolton@contentful.com.

Documentation & Help

AI Code Review powered by Bito Logo

@bito-code-review

bito-code-review Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Impact Analysis by Bito

Cross-Repository Impact Analysis
What Changed Impact of Change Suggested Review Actions
The repository package-manager pin changed from pnpm 11.25.0 to pnpm 12.5.1, and the lockfile now records pnpm 12.5.1 platform-specific executable packages. - verify-needed: external CI, contributor environments, or automation consuming the optimization repository's packageManager field: Consumers that install dependencies through Corepack or another package-manager bootstrap mechanism may resolve pnpm 12.5.1 instead of pnpm 11.25.0. The organization-wide search found no direct references to either pin in the searched repositories, but the repository dependency-graph lookup could not resolve the local repository identity. - Validate all repository CI jobs and developer bootstrap tooling with pnpm 12.5.1.
- Confirm the new pnpm lockfile entries are reproducible on Linux, macOS, Windows, x64, and arm64 runners.
- Verify that any external automation invoking package-manager setup reads the root packageManager field rather than assuming pnpm 11.
Code Paths Analyzed

Impact:
This change updates the repository toolchain from pnpm 11.25.0 to pnpm 12.5.1 and permits @parcel/watcher build scripts in the React Native implementation workspace. There are no application-code, SDK API, database, event, or network-contract changes.

Flow:
The root package.json packageManager field and pnpm-lock.yaml determine the package-manager version and resolved package-manager executable artifacts. pnpm then evaluates workspace configuration; the React Native workspace explicitly allows @parcel/watcher to run its native build scripts during installation.

Direct Changes (Diff Files):
• implementations/react-native-sdk/pnpm-workspace.yaml [3-16] — Adds @parcel/watcher: true to the workspace allowBuilds list so its native build step is permitted during installation.
• package.json [96] — Changes the packageManager pin from pnpm 11.25.0 to pnpm 12.5.1 while retaining an integrity hash.
• pnpm-lock.yaml [1-194] — Adds the pnpm 12.5.1 package-manager dependency and platform-specific @pnpm/exe optional packages to the lockfile.

Repository Impact:
• Workspace installation and CI bootstrap: All root pnpm scripts and dependency installation now execute under pnpm 12.5.1.
• React Native SDK installation: The React Native workspace can now execute @parcel/watcher's native build scripts, potentially changing installation behavior and requiring native toolchain support.
• Lockfile reproducibility: The lockfile introduces platform- and architecture-specific pnpm executable packages, so installation must be validated across supported runner platforms.

Cross-Repository Dependencies:
• Potential external CI and automation consumers of the optimization repository: Tooling may derive its package-manager version from package.json or rely on the lockfile during setup. No direct references were found in the searched repositories.

Database/Caching Impact:
• None

API Contract Violations:
• None.

Infrastructure Dependencies:
• CI runners and developer environments must support pnpm 12.5.1.
• Corepack or equivalent package-manager provisioning must accept the new packageManager integrity hash.
• React Native installation environments may need the native compiler/toolchain required by @parcel/watcher.
• Platform-specific lockfile entries should be checked on supported Linux, macOS, Windows, x64, and arm64 environments.

Additional Insights:
• Native installation scripts: Allowing @parcel/watcher to build may fix installation failures under stricter pnpm build-script approval, but it also executes additional native code during dependency installation.
• Repository intelligence coverage: The BitoAIArchitect dependency-graph lookup could not resolve the repository name, so incoming and outgoing repository relationships could not be authoritatively enumerated.

Testing Recommendations

Frontend Impact:
• None.

Service Integration:
• None.

Data Serialization:
• None.

Privacy Compliance:
• None.

Backward Compatibility:
• Run a clean install using the packageManager declaration and verify that pnpm 12.5.1 accepts the existing workspace configuration and lockfile.
• Run the existing root validation commands, including pnpm lint, pnpm typecheck, pnpm test:unit:ci, and the relevant React Native setup and end-to-end commands.
• Verify that CI and local bootstrap scripts do not depend on pnpm 11-specific behavior.

OAuth Functionality:
• None

Reliability Testing:
• None

Additional Insights:
• Run installation tests on Linux x64, Linux arm64, macOS, and Windows to validate selection of the pnpm 12.5.1 platform-specific executable packages.
• In the React Native workspace, perform a clean install and confirm @parcel/watcher's native build executes successfully without requiring undocumented manual approval.
• Verify that @parcel/watcher is the intended package requiring approval and that no unexpected native build scripts are newly enabled.
• Compare the resulting dependency tree and generated artifacts before and after the pnpm upgrade to detect resolver or peer-dependency changes.

Analysis based on known dependency patterns and edges. Actual impact may vary.

@bito-code-review

Copy link
Copy Markdown

✅ Review Settings Overridden

Status: Overridden Successfully

Guidelines:

  • Accepted:

    • General : Review Posture, Repo Truth And Boundaries, Domain Invariants

    • Language : typescript= TypeScript Review Evidence

Note: Extra guidelines beyond 3 general purpose guidelines and 1 language specific guideline per language are not processed. Guidelines are fetched from the source branch.

@bito-code-review

bito-code-review Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Code Review Agent Run #d021f4

Actionable Suggestions - 0
Additional Suggestions - 1
  • package.json - 1
    • Node min vs pnpm 12 · Line 96-96
      pnpm 12 requires Node.js 22.13+ for npm-based/corepack installation, but `engines.node` still allows `>=20.19.0`. CI is fine (`.nvmrc` = 24.15.0), but a contributor on Node 20 would hit corepack activation failure. Consider bumping `engines.node` or noting the Node 22.13+ requirement.
Review Details
  • Files reviewed - 2 · Commit Range: cafb0de..cafb0de
    • implementations/react-native-sdk/pnpm-workspace.yaml
    • package.json
  • Files skipped - 1
    • pnpm-lock.yaml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers an incremental AI Review.

  • /review full - Manually triggers a full AI Review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at jared.jolton@contentful.com.

Documentation & Help

AI Code Review powered by Bito Logo

@phobetron
Charles Hudson (phobetron) merged commit 952be72 into main Sep 21, 2026
44 checks passed
@phobetron
Charles Hudson (phobetron) deleted the update-pnpm branch September 21, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant