Skip to content

fix: remove inaccurate required markers from OAuth Issuer URL and Token URL #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marekdano wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −6
Open

fix: remove inaccurate required markers from OAuth Issuer URL and Token URL #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/components/mcp-servers/OAuth2Auth.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,27 @@ describe("OAuth2Auth", () => {
expect(screen.queryByLabelText(/Password/i)).not.toBeInTheDocument();
});

it("should not mark Issuer URL and Token URL as required (mcp-context-forge#6467)", () => {
// Neither field is actually required: they're alternatives (discovery
// via the issuer can derive the token URL, or the token URL can be
// supplied directly), and mcpServerFormSchema (useMCPServerForm.ts)
// never enforces their presence.
render(<OAuth2Auth {...defaultProps} />);

const issuerLabel = document.querySelector("label[for='oauth-issuer-url']");
const tokenLabel = document.querySelector("label[for='oauth-token-url']");
expect(issuerLabel).toHaveTextContent("Issuer URL");
expect(issuerLabel).not.toHaveTextContent("*");
expect(issuerLabel).not.toHaveTextContent("(required)");
expect(tokenLabel).toHaveTextContent("Token URL");
expect(tokenLabel).not.toHaveTextContent("*");
expect(tokenLabel).not.toHaveTextContent("(required)");

// Grant type is genuinely required and should keep its indicator.
const grantTypeLabel = document.querySelector("label[for='oauth-grant-type']");
expect(grantTypeLabel).toHaveTextContent("(required)");
});

it("should render authorization_code fields", () => {
render(<OAuth2Auth {...defaultProps} grantType="authorization_code" />);

Expand Down
8 changes: 2 additions & 6 deletions src/components/mcp-servers/OAuth2Auth.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,9 @@ export function OAuth2Auth({
<div className="space-y-1">
<label
htmlFor="oauth-issuer-url"
className="inline-flex items-center gap-0.5 text-sm font-medium text-neutral-900 dark:text-neutral-100"
className="text-sm font-medium text-neutral-900 dark:text-neutral-100"
>
{intl.formatMessage({ id: "mcpServer.auth.oauth.issuerUrlLabel" })}
<span className="text-destructive">*</span>
<span className="sr-only">{intl.formatMessage({ id: "mcpServer.form.required" })}</span>
</label>
<Input
id="oauth-issuer-url"
Expand Down Expand Up @@ -338,11 +336,9 @@ export function OAuth2Auth({
<div className="space-y-1">
<label
htmlFor="oauth-token-url"
className="inline-flex items-center gap-0.5 text-sm font-medium text-neutral-900 dark:text-neutral-100"
className="text-sm font-medium text-neutral-900 dark:text-neutral-100"
>
{intl.formatMessage({ id: "mcpServer.auth.oauth.tokenUrlLabel" })}
<span className="text-destructive">*</span>
<span className="sr-only">{intl.formatMessage({ id: "mcpServer.form.required" })}</span>
</label>
<Input
id="oauth-token-url"
Expand Down
Loading