Size the create team button by token - #123
Draft
a-effort wants to merge 1 commit into
Draft
Conversation
Create team on the Teams toolbar set h-7, px-4 and rounded-sm in its className, which beat the size variant through tailwind-merge and left it 28px tall, matching no defined size. It now takes size="sm" with no overrides, so it is 32px and agrees with the search field beside it. Its Plus gains data-icon="inline-start", which is what the size variants' has-data-[icon=...] padding rules look for. Nothing outside components/ui sets that attribute today, so no icon button in the app currently gets the padding the primitive intends. Signed-off-by: Anna Effort <anna.effort@ibm.com>
a-effort
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Create team button on the Teams toolbar set h-7, px-4 and rounded-sm in its className. Those beat the size variant through tailwind-merge, so it rendered 28px tall, matching no size on the scale. It now takes size="sm" with no overrides: 32px, which is also the height of the search field beside it, and its 6px radius now comes from the token rather than by hand.
Its Plus gains data-icon="inline-start", the attribute the size variants has-data-[icon=...] rules look for. That trims the leading padding to 6px so the glyph sits the same apparent distance from the edge as the label does on the right. Nothing outside components/ui sets that attribute today, so this is the first button in the app to get the padding the primitive intends.
Split out of #122, which touches the same element to add a ref. Whichever merges second is worth a quick look at that block.
Draft because it is a visual change and nothing in CI covers appearance. The full unit suite passes.