fix(vscode): guard theme colors lookup so a non-standard palette can't crash activation - #13168
Open
bisma-nawaz wants to merge 2 commits into
Open
fix(vscode): guard theme colors lookup so a non-standard palette can't crash activation#13168bisma-nawaz wants to merge 2 commits into
bisma-nawaz wants to merge 2 commits into
Conversation
…t crash activation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12947. Extension activation crashes with a non-standard color theme.
InlineTipManager.createSvgTooltipDecorationguarded onlyif (this.theme)and then readthis.theme.colors["editor.background"]. When the active theme produces a Monaco theme whosecolorsmap isundefined, that read throwsTypeError: Cannot read properties of undefined (reading 'editor.background'), which propagates out of the field initializer and kills activation. The twothis.theme?.colors["editor.foreground"]reads increateSvgTooltiphave the same latent unsafe access.This makes all three reads null-safe (
this.theme?.colors?.[...]), so a theme without the standard colors falls back to the existing default instead of crashing.Checklist
Screen recording or screenshot
Tests
Added
extensions/vscode/src/activation/InlineTipManager.vitest.ts, which exercisescreateSvgTooltipDecorationwith a theme whosecolorsisundefined. Before the change it throws theeditor.backgroundTypeError; after, it does not throw (and the colors-present case still works).npx vitest run src/activation/InlineTipManager.vitest.ts: before = 1 failed, after = 2 passed.