-
Notifications
You must be signed in to change notification settings - Fork 91
test: remove shared-DB and timer flakiness #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -39,7 +39,7 @@ | |||||
| "build:tui": "bun scripts/build-tui.ts", | ||||||
| "check:tui-compiled": "bun run build:tui && git diff --exit-code -- src/tui-compiled && test -z \"$(git status --porcelain -- src/tui-compiled)\"", | ||||||
| "typecheck": "tsc -p ../retina-local-fs/tsconfig.build.json && tsc --noEmit && tsc -p tsconfig.scripts.json", | ||||||
| "test": "bun test", | ||||||
| "test": "bun test --timeout 30000", | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: The new Prompt for AI agents
Suggested change
|
||||||
| "lint": "biome check .", | ||||||
| "lint:fix": "biome check --write .", | ||||||
| "format": "biome format --write .", | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The PR's stated first goal is "Enable Bun test-file isolation for plugin tests," but this change removes the
--isolateflag that was added earlier in this PR, leaving the test command with no isolation flag (only--timeout 30000). If Bun does not isolate test files into separate processes by default, the shared-state/shared-DB flakiness the PR exists to fix is not actually removed. Either restore--isolate(combined with the timeout) or confirm in the PR description that Bun isolates files by default and that isolation is intentionally dropped.Prompt for AI agents