Skip to content

fix(review): restore and clarify semantic reviews - #310

Merged
forhappy merged 2 commits into
mainfrom
codex/fix-review-uri-history-records
Sep 11, 2026
Merged

fix(review): restore and clarify semantic reviews#310
forhappy merged 2 commits into
mainfrom
codex/fix-review-uri-history-records

Conversation

@forhappy

@forhappy forhappy commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • strip flattened document and table compatibility aliases before persisting strict graph node records
  • add a history round-trip regression for URI-bearing resource nodes
  • make review text and Markdown prefer readable repository names, compact unique references, and plain-language statuses
  • summarize witness relationships without exposing opaque graph-node IDs in human output

Root cause

History compatibility projection exposes URI values as top-level compatibility properties. The strict graph realization writer removed several compatibility aliases before encoding compass.graph.node.v1 records, but it did not remove uri and related document/table aliases. Semantic diff later decoded that record with the strict NodeRecord schema and rejected the unexpected top-level field.

The fix keeps URI evidence in the typed details payload while preventing compatibility-only projections from leaking into strict stored records.

Human-readable review output

Text and Markdown now shorten commits and fingerprints, lengthening them deterministically when prefixes collide. Machine-style enum and gate names are rendered as plain language, raw witness endpoints are replaced with relationship summaries, and exact machine identities are directed to JSON. Readiness Markdown follows the same policy.

Canonical JSON and SARIF retain all full revision IDs, fingerprints, graph identities, and witness evidence.

Verification

  • cargo fmt --all -- --check
  • cargo clippy --workspace --lib --bins --locked -- -D warnings
  • cargo clippy -p compass-output --all-targets --all-features --locked -- -D warnings
  • cargo test --workspace --lib --bins --locked
  • cargo test -p compass-output --locked
  • cargo test -p compass-cli --test review_cli --locked
  • cargo test -p compass-cli --test compass_product --locked
  • sh scripts/check_product_boundary.sh
  • ./scripts/qualify_code_graph_v1.sh --fixtures-only

@forhappy
forhappy merged commit 771a067 into main Sep 11, 2026
14 checks passed
@forhappy forhappy changed the title fix(review): preserve strict URI node records fix(review): restore and clarify semantic reviews Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant