fix(review): restore and clarify semantic reviews - #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
History compatibility projection exposes URI values as top-level compatibility properties. The strict graph realization writer removed several compatibility aliases before encoding
compass.graph.node.v1records, but it did not removeuriand related document/table aliases. Semantic diff later decoded that record with the strictNodeRecordschema and rejected the unexpected top-level field.The fix keeps URI evidence in the typed
detailspayload while preventing compatibility-only projections from leaking into strict stored records.Human-readable review output
Text and Markdown now shorten commits and fingerprints, lengthening them deterministically when prefixes collide. Machine-style enum and gate names are rendered as plain language, raw witness endpoints are replaced with relationship summaries, and exact machine identities are directed to JSON. Readiness Markdown follows the same policy.
Canonical JSON and SARIF retain all full revision IDs, fingerprints, graph identities, and witness evidence.
Verification
cargo fmt --all -- --checkcargo clippy --workspace --lib --bins --locked -- -D warningscargo clippy -p compass-output --all-targets --all-features --locked -- -D warningscargo test --workspace --lib --bins --lockedcargo test -p compass-output --lockedcargo test -p compass-cli --test review_cli --lockedcargo test -p compass-cli --test compass_product --lockedsh scripts/check_product_boundary.sh./scripts/qualify_code_graph_v1.sh --fixtures-only