Skip to content

fix: use servicer type in runtime#212

Merged
negz merged 1 commit into
crossplane:mainfrom
eric-carlsson:fix/function-runner-service-type
Jun 10, 2026
Merged

fix: use servicer type in runtime#212
negz merged 1 commit into
crossplane:mainfrom
eric-carlsson:fix/function-runner-service-type

Conversation

@eric-carlsson

Copy link
Copy Markdown
Contributor

Description of your changes

Fixes #211

I have:

  • Read and followed Crossplane's contribution process.
  • Added or updated unit tests for my change. This only affects type, no runtime changes

@eric-carlsson eric-carlsson requested review from bobh66 and negz as code owners June 9, 2026 10:32
Signed-off-by: Eric Carlsson <97894605+eric-carlsson@users.noreply.github.com>
@eric-carlsson eric-carlsson force-pushed the fix/function-runner-service-type branch from a076f31 to 8eaf18b Compare June 9, 2026 10:33
@negz

negz commented Jun 10, 2026

Copy link
Copy Markdown
Member

Wow I do not love ServiceServicer but agree this does seem to be correct. Thanks!

@negz negz merged commit 574a8ee into crossplane:main Jun 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mismatched function signature

2 participants