fix: trim runtime dependencies (#36) - #42
Merged
Merged
Conversation
ts-proto is a build-time protoc plugin, but it was declared as a runtime dependency, so it shipped into every function image along with ts-poet and dprint-node — a 24MB native binary that does not compress away. The generated wire code imports @bufbuild/protobuf, which was never declared; it resolved only because ts-proto depends on it. Declare it first, then move ts-proto to devDependencies, so the runtime tree is never broken in between. google-protobuf, @types/google-protobuf and @grpc/proto-loader are not imported anywhere. The first two are leftovers from the pre-ts-proto --ts_out path, whose commented-out invocation is also removed here. @grpc/grpc-js declares proto-loader itself, so dropping it changes nothing on disk. Production dependency tree: 70MB -> 44MB. Signed-off-by: Steven Borrelli <steve@borrelli.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Reduce SDK size by removing build dependencies.
ts-proto is a build-time protoc plugin, but it was declared as a runtime dependency, so it shipped into every function image along with ts-poet and dprint-node - a 24MB native binary that does not compress away.
The generated wire code imports @bufbuild/protobuf, which was never declared; it resolved only because ts-proto depends on it. Declare it first, then move ts-proto to devDependencies, so the runtime tree is never broken in between.
google-protobuf, @types/google-protobuf and @grpc/proto-loader are not imported anywhere. The first two are leftovers from the pre-ts-proto --ts_out path, whose commented-out invocation is also removed here. @grpc/grpc-js declares proto-loader itself, so dropping it changes nothing on disk.
Production dependency tree: 70MB -> 44MB.
Fixes #
I have: