Skip to content

(cpp) Add C++ query implementation - #201

Open
daantimmer wants to merge 71 commits into
mainfrom
feature/cpp
Open

(cpp) Add C++ query implementation#201
daantimmer wants to merge 71 commits into
mainfrom
feature/cpp

Conversation

@daantimmer

@daantimmer daantimmer commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤔 What's changed?

  • Added C++ implementation for Query

⚡️ What's your motivation?

  • There was none

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

daantimmer and others added 30 commits July 19, 2026 19:03
@daantimmer
adding skeleton workspace for cpp implementation
924ac2e
@daantimmer
first two test passing
0884174
@daantimmer
Enable CountMostSevereTestStepResultStatus and FindAllPickleSteps met…
e42c783 
…hods
@daantimmer
Enabled FindAllStepDefinitions, FindAllTestCaseFinished, FindAllTestC…
4970dcb 
…aseStartedOrderBy
@daantimmer
Enabled FindAllTestCaseFinishedOrderBy. FindAllTestCases, FindAllTest…
9bef1d8 
…CaseStarted, FindAllTestRunHookFinished
@daantimmer
let each test return a json object
ca7a991
@daantimmer
Added findAllTestRunHookStarted, findAllTestStepFinished, findAllTest…
fcb6d2b 
…Steps, findAllTestStepStarted, findAllUndefinedParameterTypes, findAttachmentsBy
@daantimmer
removed obsolete tests
14572b5
@daantimmer
Added findHookBy
606501b
@daantimmer
add FindLineageBy
2b84c50
@daantimmer
Added FindLocationOf
9ff311b
@daantimmer
Added FindMeta
7718294
@daantimmer
Added FindMostSevereTestStepResultBy
a6a5c0e
@daantimmer
Added FindPickleBy, FindPickleStepBy, FindStepBy, FindStepDefinitionsBy
78f5465
@daantimmer
Added FindSuggestionsBy
cf23d8c
@daantimmer
Added FindTestCaseBy, FindTestCaseDurationBy, FindTestCaseFinishedBy,…
d007cb8 
… FindTestCaseStartedBy
@daantimmer
Added FindTestRunDuration, FindTestRunFinished, FindTestRunHookFinish…
98852ab 
…edBy, FindTestRunHookStartedBy, FindTestRunStarted
@daantimmer
Added FindTestStepBy, FindTestStepFinishedAndTestStepBy
2ad670b
@daantimmer
Merge remote-tracking branch 'origin/main' into feature/cpp
c2baac5
@daantimmer
Added FindTestStepsFinishedBy
6ffde7e
@daantimmer
Added FindTestStepsStartedBy, FindUnambiguousStepDefinitionBy
6c40e4d
@daantimmer
convert ot use trailing return types
d0b3fa5
@daantimmer
refactor TestQuery to use google test's parameterized tests
dda5e91
@daantimmer
add clang tidy preset
43b1afc
@daantimmer
Removed variants from Query
85b7d9c
@daantimmer
add gcovr feature to devcontainer configuration
e0efad9
@daantimmer
add coverage vscode settings to devcontainer
2b3ca35
@daantimmer
replace throws will nullopt returnsd
22f0564
@daantimmer
fix clang-tidy warnings
ccadca2
@daantimmer
add coverage preset/target
2a223c7
@mpkorstanje
mpkorstanje self-requested a review August 17, 2026 08:39
daantimmer and others added 9 commits August 20, 2026 22:48
@daantimmer
Refactor CMake configuration and integrate Conan for dependency manag…
7749664 
…ement
@daantimmer
Add ToJson utility function for optional values and update JSON seria…
bf7aba2 
…lization in tests
@daantimmer
Update CMake configuration and ignore compile_commands.json
75e149c 
- Change CompilationDatabase path in .clangd to current directory
- Add compile_commands.json to .gitignore
- Create custom target for clangd compile commands in CMakeLists.txt
- Update find_package for nlohmann_json and cucumber_messages
@daantimmer
Update CMakePresets.json to set build type to Debug for host-system a…
528e225 
…nd host-conan presets
@daantimmer
Update MESSAGES_REF in workflow files to match the latest dependency …
2d43235 
…version
@daantimmer
fix private include directory
ee1f3e6
@daantimmer
Remove clangd and supporting code
0c19142
@daantimmer
invert cucumber::messages dependency lookup
d39fef7
@daantimmer
Add overload helper
791a87d
mpkorstanje
mpkorstanje reviewed Aug 31, 2026
View reviewed changes
Comment thread cpp/cmake/conan_provider.cmake Outdated
mpkorstanje
mpkorstanje reviewed Aug 31, 2026
View reviewed changes
Comment thread .github/workflows/test-cpp.yaml Outdated
mpkorstanje
mpkorstanje requested changes Aug 31, 2026
View reviewed changes

@mpkorstanje mpkorstanje left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the way messages fetched. I assume Conan will fix that?

@daantimmer

daantimmer commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@mpkorstanje I am going to revert the conan changes in all honesty. I've been trying to get it to work in a satisfying and useable way. But its usability isn't on-par as to what cucumber needs sadly.

All the packages that we depend on are available in system packages, so I am updating the test builds to use those available to linux, macos and windows. The downside is we don't have control over the exact installed packages, OTOH, if the tests work with an older version than that should be fine too.

Yes conan can work with github releases but setting it up properly is a tremendous amount of manual updating dependencies.

I'll have a look at the comment w.r.t. the hash a bit later after I removed the conan things. Currently very busy on giving the cucumber/pretty-formatter a cpp makeover. And doing so I am updating Query as well to update some useability issues.

p.s. I thought I created this as a draft, but apparently vscode tricked me in to creating a non-draft. Will downgrade to draft. Sorry about that.

@daantimmer
daantimmer marked this pull request as draft August 31, 2026 20:40
@mpkorstanje

mpkorstanje commented Aug 31, 2026

Copy link
Copy Markdown
Member

Okay, no problem.

All the packages that we depend on are available in system packages, so I am updating the test builds to use those available to linux, macos and windows. The downside is we don't have control over the exact installed packages, OTOH, if the tests work with an older version than that should be fine too.

I'd prefer it if we did depend on a specific version. Waiting for system packages is a bit too slow too make a comfortable feedback cycle.

But we should depend on a specific version, not a hash. and Renovate should be able to update that. We've done that before so I hope we can reuse that mechanism.

@daantimmer

daantimmer commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@mpkorstanje I request your assistance in setting up:

  • renovate
  • VERSION release updates

@daantimmer
daantimmer marked this pull request as ready for review September 18, 2026 10:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpkorstanje mpkorstanje Awaiting requested review from mpkorstanje

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daantimmer @github-advanced-security @mpkorstanje