Skip to content

correct some intent and shared hungarian tests hungarian intent property translations#615

Open
hammera wants to merge 11 commits into
daisy:hufrom
hammera:hu
Open

correct some intent and shared hungarian tests hungarian intent property translations#615
hammera wants to merge 11 commits into
daisy:hufrom
hammera:hu

Conversation

@hammera

@hammera hammera commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Hy Boys,

In #557 issue @MartheGjelstad intent attribute tests related answer, I doed some cosmetic changes with tests/language/hu/shared.rs file and tests/languages/hu/intent.rs files related.
Previous, the „perpendicular to” string, the „testing of” string parts (normal and prefix type test), and the „forced” string parts are presents untranslated, because I not known previous this string parts are need translate inside the MathML expression the intent attribute part into the affected tests, not with any Rules/Languages/hu awailable rule files. :-):-)
Have two test with me need restore after the main branch merge happened, because have differences the april 24 branch state of the hu branch and the actual branch state with two tests related.
So, now only have 523 hungarian tests again.

In my local machine following commands ran successfull:

  • cargo build,
  • cargo test Languages::hu,
  • cargo test --lib (navigation tests),
  • cargo check.

Cargo clippy me drops following output:

warning: casting to the same type is unnecessary (`u32` -> `u32`)
    --> src/speech.rs:2828:147
     |
2828 | ...32(*ch).unwrap(), *ch as u32);
     |                      ^^^^^^^^^^ help: try: `{ *ch }`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_cast
     = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: `mathcat` (lib) generated 1 warning (run `cargo clippy --fix --lib -p mathcat` to apply 1 suggestion)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s

Cargo test command drops me following result, I copyed only end of results:

failures:
    braille::Swedish::swedish::ex_6_15
    braille::Swedish::swedish::ex_6_16
    braille::Swedish::swedish::ex_6_19

test result: FAILED. 1422 passed; 3 failed; 31 ignored; 0 measured; 0 filtered out; finished in 6.22s

This result is equals the friday evening result, when the merge happened from the hu branch of the main branch.

Please merge this corrected tests into the github.com/daisy/mathcat repository hu branch, and after this merge, if this is possible please merge this change to the github.com/daisy/mathcat repo main branch too.

Thank you the very good cooperation,

Attila

@hammera

hammera commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Cargo clippy related online workflow check produce exit code 101 error.
The log file show following, this is I think not related the hungarian tests related fix with I committed this day.
If this is not the case, please tell me what can me need fixing the affected test Rust files and I will doing the proper fix.
The log file output:

    Checking env_logger v0.11.11
error: casting to the same type is unnecessary (`u32` -> `u32`)
    --> src/speech.rs:2828:147
     |
2828 | ... unicode tables", char::from_u32(*ch).unwrap(), *ch as u32);
     |                                                    ^^^^^^^^^^ help: try: `{ *ch }`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#unnecessary_cast
     = note: `-D clippy::unnecessary-cast` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`

error: could not compile `mathcat` (lib) due to 1 previous error
Error: Process completed with exit code 101.

Attila

@hammera

hammera commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

I synced my feature branch with the main repository, now more Github online workflow checks passed.
Very interesting, but after syncing the main branch and merge two branches with an interactive rebase, cargo test command shows me a failure with hungarian intent test in intent_prob_x function, without the left and right expression. If I ran only the cargo test Languages::hu command, the hungarian tests passed (perhaps a phantom failure because logging turned on the intent_prob_x function)?
After I commented out the init_logger(); function call into the hungarian intent.rs file intent_prob_x function, entire cargo test command pass successfull after branch syncing, and of course the normal cargo test Languages::hu test command pass too, produce wanted result the language tests.

Attila

@hammera hammera force-pushed the hu branch 2 times, most recently from a77a036 to 9ea8047 Compare July 3, 2026 09:15
NSoiffer and others added 9 commits July 3, 2026 12:09
…e of months ago.

There are still a few other places that need to be wrapped, but this was the bulk of the places.
In discussions with Anders, we are still trying to work out the rationale for why they do what they do. He said the spec may need to change to be less ad-hoc. In the meantime, no one has complained in 2 years. Also, many more tests need to be added.

The tests were turned off for two years by accident. They are now back on.
…rty translations

Signed-off-by: Attila Hammer <hammera@pickup.hu>
…intent.rs file

Signed-off-by: Attila Hammer <hammera@pickup.hu>
@hammera

hammera commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Now everithing looks fine, previous force-push operation not added with @NSoiffer june 29 doed clippy fix.
Now builds related online workflow checks are passed, the fuzzing related check require more time to run successfull (yesterday evening require about 45 minutes to ran).
So, following checks now ran successfull:

  • clippy lint check,
  • Rust build and test,
  • Python related check,
  • Rules directory zipping.
    Now still running the Fuzz / Build and fuzz (with MathML dict + corpus cache) online workflow check.

Attila

@hammera

hammera commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Very nice, now all online Github workflow checks are passed.

hammera added 2 commits July 5, 2026 22:26
…ak large operations tests

Signed-off-by: Attila Hammer <hammera@pickup.hu>
…slations

Signed-off-by: Attila Hammer <hammera@pickup.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants