Skip to content

Example notebook for DANDI:001550#136

Merged
bendichter merged 5 commits into
dandi:masterfrom
catalystneuro:001550
Jun 16, 2026
Merged

Example notebook for DANDI:001550#136
bendichter merged 5 commits into
dandi:masterfrom
catalystneuro:001550

Conversation

@weiglszonja

Copy link
Copy Markdown
Contributor

No description provided.

@weiglszonja weiglszonja marked this pull request as draft April 14, 2026 13:55
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bendichter

Copy link
Copy Markdown
Member

@weiglszonja is this PR ready for review?

@weiglszonja weiglszonja marked this pull request as ready for review June 16, 2026 10:40
@weiglszonja

Copy link
Copy Markdown
Contributor Author

@weiglszonja is this PR ready for review?

Yes!

bendichter and others added 3 commits June 16, 2026 13:56
Bring the two Pagan Lab notebooks up to the current Colab/CI requirements:

- Prepend the four bootstrap cells (Colab badge, install intro, collapsed
  `#@title display-mode: form` install cell, restart admonition).
- Pin a full transitive lock via `uv pip compile`, constrained to Colab's
  preinstalled versions (numpy 2.0.2, matplotlib 3.10.0, networkx 3.6.1,
  pandas 2.2.2, h5py 3.16.0). dandi resolves to 0.76.4 (the DANDI server now
  rejects <0.74.0); the click constraint is relaxed to allow it.
- Pin the git-sourced ndx-structured-behavior to commit b3169248 (was @main)
  in both the install cell and environment.yml, for reproducibility.
- Strip pre-existing invalid `jetTransient` output keys so the notebooks
  validate against nbformat.

Both notebooks verified end-to-end with the CI harness (ok: true).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
"FOF" (Frontal Orienting Field) and "inactivate" (transiently silencing a
brain region) are correct neuroscience terms that codespell flags as
"FOR"/"deactivate". Add them to the ignore list.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@bendichter

Copy link
Copy Markdown
Member

Brought this PR up to the current Colab/CI requirements and resolved the conflict with master. Both notebooks now pass CI end-to-end (and I verified them locally with .github/scripts/run_notebook.pyok: true).

What changed:

  • Prepended the four Colab-bootstrap cells to both notebooks (Colab badge, install intro, collapsed #@title display-mode: form install cell, restart admonition), matching the #149 pattern documented in docs/adding-notebooks.md.
  • Generated a fully pinned transitive lock via uv pip compile, constrained to Colab's preinstalled versions (numpy 2.0.2, matplotlib 3.10.0, networkx 3.6.1, pandas 2.2.2, h5py 3.16.0).
  • dandi resolves to 0.76.4. The DANDI server now rejects clients <0.74.0, and the current colab-preinstalled.txt pins click==8.3.3 which (via the constraint) was pinning dandi back to 0.68.1. I relaxed the click constraint so dandi can be current; the minor click downgrade in Colab is covered by the restart admonition.
  • Pinned ndx-structured-behavior to commit b3169248 (was @main) in both the install cell and environment.yml, for reproducibility.
  • Stripped pre-existing invalid jetTransient output keys so the notebooks validate against nbformat.
  • Added fof (Frontal Orienting Field) and inactivate to the codespell ignore list — both are correct neuroscience terms.

No headless gotchas: all plotting is matplotlib (plt.show() / networkx via Agg), which runs fine in CI.

@bendichter bendichter merged commit 195ff0d into dandi:master Jun 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants