fix: isolate Symphony GitHub token - #88
Draft
dapi wants to merge 3 commits into
Draft
Conversation
dapi
commented
Jul 30, 2026
dapi
left a comment
dapi
left a comment
Owner
Author
There was a problem hiding this comment.
Симфони не должна ничего знать про .env* файлы, пользователь должен сам позаботиться об установке переменных окурежния
| `gh` CLI for GitHub reads and updates. | ||
| - Provide a GitHub token for Symphony's tracker as `SYMPHONY_GITHUB_TOKEN`. | ||
| If it is absent, `.envrc` uses `gh auth token` for the tracker. The agent | ||
| continues to use its authenticated `gh` CLI for GitHub reads and updates. |
Owner
Author
There was a problem hiding this comment.
Убери эти исправления. Симфони не должна ничего знать про .env* файлы, пользователь должен сам позаботиться об установке переменных окурежния
| It expects the GitHub token at `pass:github/homebrew-token`. If the local | ||
| password-store layout differs, change only the ignored `.env.local`; never add | ||
| the literal token to a tracked file. | ||
| Set `SYMPHONY_GITHUB_TOKEN` in the ignored `.env.local`; never add the literal |
Owner
Author
There was a problem hiding this comment.
Симфони не должна ничего знать про .env* файлы, пользователь должен сам позаботиться об установке переменных окурежния
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Exporting GITHUB_TOKEN caused gh to prefer Symphony tracker credentials, which may not have pull-request write permission.
Verification