Upgrade cryptography v46.0.7 -> v49.0.0#1111
Open
acroca wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
- Coverage 86.63% 82.08% -4.55%
==========================================
Files 84 116 +32
Lines 4473 9578 +5105
==========================================
+ Hits 3875 7862 +3987
- Misses 598 1716 +1118 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dev/test dependency set to address a Dependabot security alert by upgrading cryptography and removing pyOpenSSL, switching the unit-test certificate generation code to use cryptography directly.
Changes:
- Upgraded
cryptographyin the lockfile and removedpyOpenSSLfrom the resolved dependency graph. - Replaced
pyOpenSSL-based certificate generation in tests withcryptography.x509+cryptography.hazmat. - Updated
pyproject.tomldev dependency list to removepyOpenSSLand requirecryptography.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uv.lock | Updates resolved cryptography to 49.0.0 and removes pyopenssl from dev/test resolution. |
| tests/clients/certs.py | Migrates self-signed cert/key generation from pyOpenSSL to cryptography. |
| pyproject.toml | Removes pyOpenSSL from dev deps and updates the cryptography constraint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b5d6b6f to
b91ea93
Compare
Signed-off-by: Albert Callarisa <albert@diagrid.io>
b91ea93 to
a475a7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix security alert: https://github.com/dapr/python-sdk/security/dependabot/56
Removed
pyOpenSSLas a dependency, and usedcryptograpy 49.0.0directly for the small usecase we had forpyOpenSSL.