refactor: resolve nuclear review findings#118
Merged
Conversation
The main window can only be moved by grabbing the strip right next to the traffic lights. Clicking the empty space in the sidebar below the tab list now moves the window too, using the same WindowDragHandleView the titlebar already uses, mounted as a frontmost overlay so it actually receives the clicks. Double-clicking that area still creates a new workspace: the drag handle now owns the full double-click sequence via a new onDoubleClick callback instead of racing a sibling SwiftUI tap gesture for it. Existing call sites keep their default zoom/minimize behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve correctness, ownership, concurrency, build, and dependency findings from the whole-codebase nuclear review. The first commit intentionally contains regression tests and runtime seams only so CI records the pre-fix failures.
Test Plan
./scripts/reload.sh --tag nuclear-fixeswith isolated Zig 0.15.2