Skip to content

Enable DCO enforcement #438

Description

@mlieberman85

Current state

  • 1 of the last 20 commits carries Signed-off-by.
  • No DCO check exists. .github/workflows/ has 10 workflows, none of
    which verify sign-off.
  • Repo is Apache-2.0.

Why now

PR #434 adds AI_POLICY.md, whose "Signed-off-by and Developer
Certificate of Origin" section requires human contributors to add their
own Signed-off-by and prohibits AI agents from adding one. That
section describes a process that is not currently enforced.

Options

  1. GitHub's DCO app (https://github.com/apps/dco) -- adds a required
    status check, no workflow to maintain.
  2. A CI workflow check -- more control over exemptions and error
    messaging, one more workflow to own.

Decisions needed

  • Retroactive or forward-only? Enforcing against existing history
    would fail nearly every open PR. Forward-only (check only the commits
    in a PR) is the usual choice.
  • Bot exemption. Dependabot commits appear throughout recent history
    and do not sign off. Both options above support bot allowlists; pick
    one explicitly rather than discovering it on the first failing
    Dependabot PR.
  • Contributor impact. Enforcement means every contributor needs
    git commit -s or equivalent. Worth a line in CONTRIBUTING.md at
    the same time.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions