fix(platform-wallet): support HASH160 DashPay profile signing keys - #4653
Draft
lklimek wants to merge 1 commit into
Draft
fix(platform-wallet): support HASH160 DashPay profile signing keys#4653lklimek wants to merge 1 commit into
lklimek wants to merge 1 commit into
Conversation
Share the active HIGH/CRITICAL authentication key selector across profile creation and replacement, accepting both ECDSA public-key representations. Add regression coverage for HASH160 identities and ineligible keys. Co-Authored-By: Codex <noreply@openai.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Allow users whose identity uses hashed ECDSA keys to create and update their DashPay profile.
User story
As a wallet user, I can save my profile with my existing identity keys.
Scenario
An identity has a master authentication key, a high-security authentication key, and a transfer key, all stored as public-key hashes. Profile writes currently fail with a missing-authentication-key error. The high-security key should authorize the write.
Detailed discussion
Issue being fixed or feature implemented
Related to dashpay/dash-evo-tool#760. The platform-wallet external-signer profile paths restrict eligible keys to ECDSA_SECP256K1, excluding ECDSA_HASH160 before invoking the signer.
What was done?
Both profile creation and replacement use one selector accepting ECDSA_SECP256K1 and ECDSA_HASH160. It continues to require enabled AUTHENTICATION keys at HIGH or CRITICAL security. The supplied signer remains responsible for the selected key.
How Has This Been Tested?
cargo test -p platform-wallet --lib wallet::identity::network::profile::tests --locked: 10 passed. Covers both ECDSA types at HIGH/CRITICAL, the reported three-key identity, and rejection of disabled, MASTER, MEDIUM, TRANSFER, unsupported-type, and absent keys.cargo fmt -p platform-wallet -- --check: passed.cargo clippy -p platform-wallet --all-targets --all-features --locked -- --no-deps -D warnings: passed (existing dependency warning in Drive).Breaking Changes
None.
Checklist
🤖 Co-authored by Claudius the Magnificent AI Agent