Skip to content

[🍒] Add TRANSACTION_ISOLATION_LEVEL config in cloudsql-postgres and cloudsql-mysql plugins for 1.11#677

Open
vishwasvaidya-cloudsufi wants to merge 2 commits into
data-integrations:release/1.11from
cloudsufi:transaction-isolation-level-cherrypick-1.11
Open

[🍒] Add TRANSACTION_ISOLATION_LEVEL config in cloudsql-postgres and cloudsql-mysql plugins for 1.11#677
vishwasvaidya-cloudsufi wants to merge 2 commits into
data-integrations:release/1.11from
cloudsufi:transaction-isolation-level-cherrypick-1.11

Conversation

@vishwasvaidya-cloudsufi

Copy link
Copy Markdown

[🍒]

🍒 [cherrypick]

PR : (#675)

Description:

Add TRANSACTION_ISOLATION_LEVEL config in cloudsql-postgres and cloudsql-mysql plugins

vedanshugarg04 and others added 2 commits July 21, 2026 16:41
…sql-mysql plugins for develop

fix: updated widget and docs

fix: typos

Added a constant for default isolation level
@google-cla

google-cla Bot commented Jul 21, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for configuring the transaction isolation level in CloudSQL MySQL and CloudSQL PostgreSQL plugins, updating documentation, widget configurations, and source configurations. The review feedback highlights that both CloudSQLMySQLSource and CloudSQLPostgreSQLSource should honor the transaction isolation level configured in the connection when useConnection is enabled, rather than falling back to the local source configuration or default value.

Comment on lines +163 to +166
@Override
public String getTransactionIsolationLevel() {
return transactionIsolationLevel != null ? transactionIsolationLevel : DEFAULT_TRANSACTION_ISOLATION_LEVEL;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

When useConnection is enabled, the source should honor the transaction isolation level configured in the connection rather than falling back to the source's local configuration or default value. Currently, connection.getTransactionIsolationLevel() is ignored.

    @Override
    public String getTransactionIsolationLevel() {
      if (useConnection != null && useConnection && connection != null) {
        return connection.getTransactionIsolationLevel();
      }
      return transactionIsolationLevel != null ? transactionIsolationLevel : DEFAULT_TRANSACTION_ISOLATION_LEVEL;
    }

Comment on lines +168 to +171
@Override
public String getTransactionIsolationLevel() {
return transactionIsolationLevel != null ? transactionIsolationLevel : DEFAULT_TRANSACTION_ISOLATION_LEVEL;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

When useConnection is enabled, the source should honor the transaction isolation level configured in the connection rather than falling back to the source's local configuration or default value. Currently, connection.getTransactionIsolationLevel() is ignored.

    @Override
    public String getTransactionIsolationLevel() {
      if (useConnection != null && useConnection && connection != null) {
        return connection.getTransactionIsolationLevel();
      }
      return transactionIsolationLevel != null ? transactionIsolationLevel : DEFAULT_TRANSACTION_ISOLATION_LEVEL;
    }

@vikasrathee-cs vikasrathee-cs changed the title [🍒] Add TRANSACTION_ISOLATION_LEVEL config in cloudsql-postgres and cloudsql-mysql plugins for develop [🍒] Add TRANSACTION_ISOLATION_LEVEL config in cloudsql-postgres and cloudsql-mysql plugins for 1.11 Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants