Conversation
The maintainer-approval workflow treated any historical APPROVED review as current, so a later CHANGES_REQUESTED review from the same user did not revoke approval. The workflow now reduces reviews to the latest state per reviewer before evaluating maintainer, maintainer-authored, and per-path approvals. Constraint: GitHub returns the full review history, but the approval decision should reflect each reviewer's current state. Rejected: Filter out CHANGES_REQUESTED reviews only | stale approvals would still count after later comments or dismissals Confidence: high Scope-risk: narrow Tested: node --test .github/workflows/maintainer-approval.test.js Related: databricks#5322
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
|
This PR has not received an update in a while. If you want to keep this PR open, please leave a comment below or push a new commit and auto-close will be canceled. |
Member
|
Superseded by #6709 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5322
Tests
node --test .github/workflows/maintainer-approval.test.js