job_runs: include resource key in deploy progress lines - #6227
Open
radakam wants to merge 4 commits into
Open
Conversation
Make concurrent job_runs deploys easier to tell apart by attaching the bundle resource key in the direct engine and formatting cmdio lines as "Output from job_runs.foo: id=…: …".
Satisfy testifylint so CI lint passes on the resource key round-trip test.
radakam
marked this pull request as ready for review
August 11, 2026 11:30
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 2f4aaca
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 14 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
job_runscmdio progress asOutput from job_runs.foo: id=…: …so concurrent runs are distinguishableWhy
Follow-up from review on wait-for-completion: multi-run deploys only showed a numeric run id (
job run 123: …), which is hard to map back to config.Tests
TestReportRunLineIncludesResourceKey,TestResourceKeyRoundTripgo test ./acceptance -run TestAccept/bundle/resources/job_runs/