AIR CLI: attach docker_image_url to the run (follow-up to #6165) - #6237
Open
riddhibhagwat-db wants to merge 1 commit into
Open
AIR CLI: attach docker_image_url to the run (follow-up to #6165)#6237riddhibhagwat-db wants to merge 1 commit into
riddhibhagwat-db wants to merge 1 commit into
Conversation
riddhibhagwat-db
force-pushed
the
air-integration-m6-2
branch
from
August 11, 2026 18:47
6c9f0b8 to
4597837
Compare
riddhibhagwat-db
force-pushed
the
air-integration-m6-3
branch
from
August 11, 2026 18:47
8d0ab36 to
9ae0b4a
Compare
riddhibhagwat-db
marked this pull request as ready for review
August 11, 2026 18:55
Collaborator
Integration test reportCommit: 9ae0b4a
Top 5 slowest tests (at least 2 minutes):
|
ben-hansen-db
approved these changes
Aug 11, 2026
Follow-up to the docker-image wiring: set ai_runtime_task.docker_image_url from environment.docker_image.url so a registered custom image is actually used by the run (the parent PR verifies the image but does not yet attach it). REQUIRES an SDK bump: docker_image_url was added to jobs.AiRuntimeTask in databricks-sdk-go after v0.170.0, and the CLI is pinned to v0.166.0. This one line does not compile until the CLI bumps the SDK (a separate PR that also regenerates the command stubs). Merge only after that bump lands; the code was verified green against the SDK commit that has the field. Re-adds the two buildSubmitPayload tests covering the field set and omitted. Co-authored-by: Isaac
riddhibhagwat-db
force-pushed
the
air-integration-m6-3
branch
from
August 12, 2026 00:49
9ae0b4a to
1e780a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Sets
ai_runtime_task.docker_image_urlfromenvironment.docker_image.urlinbuildSubmitPayload, so a registered custom image is actually attached to the run — the last step of the docker-image wiring. Re-adds the twobuildSubmitPayloadtests (field set / field omitted).Why
The parent work (#6165, now merged to
main) verifies the image (config parse +prepareDockerImagepreflight) but intentionally does not attach it to the submit payload, because thedocker_image_urlfield onjobs.AiRuntimeTaskwas added todatabricks-sdk-goafter v0.170.0 andmainis pinned to v0.166.0. Setting the field there would break the build, so it was split into this follow-up.This one-line change is that deferred step. It has a hard dependency the parent did not:
Important
Blocked on an SDK bump. Do not merge until
main'sdatabricks-sdk-gois bumped to a release that includesAiRuntimeTask.docker_image_url(the field is on SDKmainvia databricks/databricks-sdk-go#1800, pending a release tag). That bump is its own PR (it also regenerates command stubs). Until it lands, this branch does not compile against the pinned SDK and CI will be red — expected.Verified green (
go test,golangci-lint,gofmt) against the SDK commit that has the field. Once the SDK bump merges, rebase this branch and it goes green with no further changes.Tests
TestBuildSubmitPayloadDockerImage(field set from config) andTestBuildSubmitPayloadNoDockerImage(empty when no image) — both pass against the SDK that has the field; they cannot compile until the bump.Base
Rebased onto
main(the parent #6165 has merged).This pull request and its description were written by Isaac.