direct: make migration ignore direct-only resources

[denik]

Why

With a terraform state, adding a direct-only resource (instance pool, catalog, ...) and opting in via engine: direct made bundle deploy fail in pre-deploy checks, so the state never migrated and there was no way forward.

Such resources are new by definition, since terraform could never deploy them. When the direct engine is requested but the state is still terraform, they are now skipped by this run (bundle plan reports them as skip) and created by the next deploy, which runs on the migrated state.

The flag lives on bundle.Bundle, so bundle destroy skips them as well — terraform never created them, so there is nothing to destroy. Without the opt-in nothing changes: direct-only resources are still rejected.

Tests

Three acceptance tests, one per migration path: bundle deployment migrate (which already ignored them), engine: direct, and DATABRICKS_BUNDLE_ENGINE=direct.

[eng-dev-ecosystem-bot]

Integration test report

Commit: e0d19d0

Run: 31695727721

	Env	🔄​flaky	💚​RECOVERED	🙈​SKIP	✅​pass	🙈​skip	Time
💚​	aws linux		4	4	286	1139	5:11
💚​	aws windows		4	4	288	1137	5:11
🔄​	azure linux	2	4	4	283	1139	5:37
💚​	azure windows		4	4	287	1137	5:19
💚​	gcp linux		1	5	286	1139	5:03
💚​	gcp windows		1	5	288	1137	5:21

10 interesting tests: 4 RECOVERED, 4 SKIP, 2 flaky

	Test Name	aws linux	aws windows	azure linux	azure windows	gcp linux	gcp windows
💚​	TestAccept	💚​R	💚​R	💚​R	💚​R	💚​R	💚​R
🙈​	TestAccept/bundle/invariant/no_drift	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S
🙈​	TestAccept/bundle/resources/vector_search_endpoints/drift/recreated_same_name	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S
🙈​	TestAccept/bundle/resources/vector_search_indexes/recreate/embedding_dimension	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S
🙈​	TestAccept/ssh/connection	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S
🔄​	TestFsCpDirToDirWithOverwriteFlag	✅​p	✅​p	🔄​f	✅​p	✅​p	✅​p
🔄​	TestFsCpDirToDirWithOverwriteFlag/uc-volumes_to_uc-volumes	✅​p	✅​p	🔄​f	✅​p	✅​p	✅​p
💚​	TestFetchRepositoryInfoAPI_FromRepo	💚​R	💚​R	💚​R	💚​R	🙈​S	🙈​S
💚​	TestFetchRepositoryInfoAPI_FromRepo/root	💚​R	💚​R	💚​R	💚​R
💚​	TestFetchRepositoryInfoAPI_FromRepo/subdir	💚​R	💚​R	💚​R	💚​R

Top 6 slowest tests (at least 2 minutes):

duration	env	testname
5:10	gcp windows	TestAccept
5:09	azure windows	TestAccept
5:02	aws windows	TestAccept
3:02	azure linux	TestAccept
2:58	aws linux	TestAccept
2:50	gcp linux	TestAccept

[andrewnester]

Do we need this? This seems to be covered by acceptance tests anyway and we agreed not to unit tests mutators

[denik]

no, good point.