Skip to content

dresources: document why RemapState is skipped when types match - #6777

Draft
denik wants to merge 1 commit into
mainfrom
denik/remapstate-identity-comment
Draft

denik wants to merge 1 commit into
mainfrom
denik/remapstate-identity-comment

Conversation

@denik

@denik denik commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Adapter.RemapState returns the remote unchanged when a resource has no RemapState method. That's only correct because validate() requires remoteType == stateType in that case, but the fallback branch didn't say so. Add a comment.

This pull request and its description were written by Isaac.

…s state type

Co-authored-by: Isaac <no-reply@databricks.com>
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: a1c5adb

Run: 35616056575

Env 🔄​flaky ✅​pass 🙈​skip Time
✅​ aws linux 276 15 6:29
✅​ aws windows 278 13 5:58
✅​ azure linux 275 15 5:59
✅​ azure windows 277 13 5:31
✅​ gcp linux 276 15 6:16
🔄​ gcp windows 1 277 13 6:12
Test Name gcp windows
🔄​ TestAccept 🔄​f
Top 3 slowest tests (at least 2 minutes):
duration env testname
5:55 aws windows TestAccept
4:32 azure windows TestAccept
2:39 gcp windows TestAccept

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants