bundle: report deployment history in deploy telemetry - #6779
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: d654b80
Top 3 slowest tests (at least 2 minutes):
|
shreyas-goenka
changed the base branch from
shreyas-goenka/cli-managed-state-flag
to
main
September 23, 2026 10:39
shreyas-goenka
force-pushed
the
shreyas-goenka/deployment-history-telemetry
branch
from
September 23, 2026 10:39
fbe852b to
9016e76
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka/deployment-history-telemetry
branch
2 times, most recently
from
September 23, 2026 11:26
14b85a6 to
ad3a852
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka/deployment-history-telemetry
branch
from
September 23, 2026 11:34
ad3a852 to
d654b80
Compare
shreyas-goenka
marked this pull request as ready for review
September 23, 2026 12:02
shreyas-goenka
requested review from
denik,
lennartkats-db and
renaudhartert-db
September 23, 2026 12:02
denik
approved these changes
Sep 23, 2026
shreyas-goenka
deleted the
shreyas-goenka/deployment-history-telemetry
branch
September 23, 2026 13:31
Collaborator
Integration test reportCommit: 37d49f1
113 interesting tests: 102 FAIL, 11 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Record
deployment_history_enabledin bundle deploy telemetry using the existing state database'sIsDeploymentMetadataService()predicate. This reports actual DMS use, including after state finalization, and emits an explicit false for file-backed deployments.Two production lines, focused telemetry goldens, and normalization of this matrix-dependent value in unrelated acceptance fixtures; based directly on
main.Testing
go test ./bundle/phases ./bundle/metrics