-
Notifications
You must be signed in to change notification settings - Fork 238
ssh: always re-upload dev builds of the tunnel binary #6820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+62
−19
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Gap (Nit)] Test asserts getRelease was called, not that overwrite landed
TestUploadReleasesWithExistingBinarydoes fail without the skip fix: both cases seedremoteBinaryPath, soStatsucceeds, and the pre-fix loop wouldcontinuefor the dev version too. That part is good, and the release case is a useful guard against “always upload.” It does not, however, assert overwrite. AfteruploadReleasesthe test only compares theuploadedslice; it neverReads anything. Setup writes"old"to{release}/databricks(theStatpath). Production writes"new"to{release}/databricks.zipwithfiler.OverwriteIfExists. Those are different paths. UnderLocalClient, the zip path does not exist yet, soWritewould succeed even withoutOverwriteIfExists. The case named “dev version overwrites the binary” therefore does not show that new bytes replaced old ones.LocalClientalso does not unzip, so it cannot honestly assert thedatabricksfile content anyway.Suggestion: After a successful upload, for the dev case
Read{release}/databricks.zipand assert the body is"new"; for the release case assert that zip was not created and{release}/databricksis still"old". Stronger still: also pre-seed the zip path with"old"so droppingOverwriteIfExistsfails locally. Do not assert{release}/databricksbecame"new"in this unit test — that only happens via workspaceimport-fileunzip.