ssh: wait up to 5 minutes for the server to start - #6821
Merged
Merged
Conversation
After the bootstrap task reaches RUNNING, the client allowed only 60 seconds (30 retries x 2s) for the server to write metadata.json. A first-time bootstrap on a cold cluster regularly overran that and failed with a server metadata error, while an immediate retry succeeded. The wait already ends early when the run terminates, so the longer cap only applies while the run is alive. Co-authored-by: Isaac <no-reply@databricks.com>
anton-107
requested review from
rclarey and
renaudhartert-db
and removed request for
renaudhartert-db
September 23, 2026 14:36
Collaborator
Integration test reportCommit: c4244ae
Top 3 slowest tests (at least 2 minutes):
|
rclarey
approved these changes
Sep 24, 2026
Collaborator
Integration test reportCommit: 8d64346
11 interesting tests: 8 flaky, 3 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Once the bootstrap task reaches RUNNING,
ensureSSHServerIsRunningnow waits up to 5 minutes for the server'smetadata.json, up from 60 seconds (30 retries x 2s). The timeout and poll interval are now named constants. There's no flag or env override.Why
A first-time bootstrap on a cold cluster regularly took longer than 60 seconds and failed with a server metadata error, while an immediate retry succeeded. The loop already returns early when the run terminates (
runFailureIfTerminated), so the longer cap only applies while the run is still alive.Tests
experimental/sshtests pass.TestSSHServerBootstrapfails locally onmaintoo, because the local interpreter is Python 3.6.This pull request and its description were written by Isaac.