Validate build-time SDK generation with google-java-format - #923
Closed
hectorcast-db wants to merge 1 commit into
Closed
hectorcast-db wants to merge 1 commit into
hectorcast-db wants to merge 1 commit into
Conversation
Draft PR to validate the Databricks Universe build-time SDK generation against this repo's CI. The SDK surface and the generated test suite are rendered from the OpenAPI spec at build time and formatted in place with google-java-format (run to a fixed point), replacing the committed generated code and the Maven Spotless lint: - Surface + generated tests formatted by google-java-format; the test files come out byte-identical to the current formatting (0 test-file changes here), confirming the generate-time formatter matches Spotless's output. - Spotless removed from the build (pom, the CI "Check formatting" step, the Makefile targets, scripts/mvn-spotless-apply.sh): the generator is now authoritative, so a second formatter here would only risk drift. - Release/changelog tooling (tagging.py, the tagging and next-changelog workflows, NEXT_CHANGELOG.md) is dropped; releases move to the Universe pipeline. - Remaining source changes are ordinary API evolution since v0.156.0. Not for merge -- this validates formatting and CI only. Signed-off-by: Hector Castejon Diaz <hector.castejon@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
Author
|
Validation complete — all 18 CI checks passed (fmt, unit-tests matrix ×8, Integration Tests, release dry-run, secrets-access check), confirming the build-time-generated and google-java-format-formatted SDK surface and test suite compile and pass across Java 8/11/17/20 with Spotless removed. This was a throwaway validation branch (not for merge); closing now that the result is captured. The actual change lands via the internal build-time-generation stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
The SDK surface and the generated test suite are rendered from the OpenAPI spec at build time and formatted in place with google-java-format (run to a fixed point), then synced here. This PR shows the result against
main(v0.156.0).Changes
pom.xml, the CI "Check formatting" step, thefmt/fmt-jdk17Makefile targets,scripts/mvn-spotless-apply.sh). The generator is now authoritative, so a second formatter here would only risk drift.tagging.py, the tagging and next-changelog workflows, andNEXT_CHANGELOG.md— releases move to the build pipeline.Why
The generated SDK is about to be reviewable per-PR in a diff viewer, so the emitted tree must be cleanly and consistently formatted — including the tests. This PR confirms the formatting is stable and that CI is green without Spotless.
This pull request and its description were written by Isaac.