Skip to content

Add managed-config serializer, validation, and per-agent model catalogs #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tt-le wants to merge 1 commit into
base: main
Choose a base branch
from
+1,244 −7
Open

Add managed-config serializer, validation, and per-agent model catalogs #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/ucode/managed_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@
NO_MANAGED_CONFIG_MESSAGE = "No coding-agent config has been set up by your workspace admin yet."

# CodingAgent proto enum -> ucode tool name. Anything unrecognized (e.g. a newer agent this ucode
# build doesn't know) is dropped during normalization rather than guessed at.
_AGENT_ENUM_TO_TOOL: dict[str, str] = {
# build doesn't know) is dropped during normalization rather than guessed at. Public because the
# admin-write side (``managed_setup``) inverts these maps to serialize, so a new agent or MCP type
# only has to be declared once.
AGENT_ENUM_TO_TOOL: dict[str, str] = {
"CODING_AGENT_CLAUDE_CODE": "claude",
"CODING_AGENT_CODEX": "codex",
"CODING_AGENT_GEMINI": "gemini",
Expand All @@ -48,7 +50,7 @@

# McpServerType proto enum -> ucode's short type tag. Mirrors the selection prefixes in ``mcp.py``;
# the actual name->URL resolution happens there when the manifest is applied (a later change).
_MCP_TYPE_ENUM_TO_TAG: dict[str, str] = {
MCP_TYPE_ENUM_TO_TAG: dict[str, str] = {
"MCP_SERVER_TYPE_UC_SERVICE": "mcp-service",
"MCP_SERVER_TYPE_EXTERNAL": "external",
"MCP_SERVER_TYPE_GENIE": "genie-space",
Expand Down Expand Up @@ -130,7 +132,7 @@ def _normalize_enabled_agent(entry: object) -> tuple[str, dict] | None:
entry_dict = _as_dict(entry)
if not entry_dict:
return None
tool = _AGENT_ENUM_TO_TOOL.get(_str(entry_dict.get("agent")) or "")
tool = AGENT_ENUM_TO_TOOL.get(_str(entry_dict.get("agent")) or "")
if tool is None:
return None
config_in = _as_dict(entry_dict.get("config"))
Expand Down Expand Up @@ -165,7 +167,7 @@ def _normalize_mcp_servers(value: object) -> list[dict]:
for entry in value:
entry_dict = _as_dict(entry)
name = _str(entry_dict.get("name"))
tag = _MCP_TYPE_ENUM_TO_TAG.get(_str(entry_dict.get("type")) or "")
tag = MCP_TYPE_ENUM_TO_TAG.get(_str(entry_dict.get("type")) or "")
if name and tag:
out.append({"name": name, "type": tag})
return out
Expand All @@ -190,7 +192,7 @@ def _normalize_budget_policy(value: object) -> dict | None:
if not isinstance(pct, (int, float)) or isinstance(pct, bool):
continue
tier_out: dict = {"spending_percentage": float(pct)}
agent = _AGENT_ENUM_TO_TOOL.get(_str(tier_dict.get("default_agent")) or "")
agent = AGENT_ENUM_TO_TOOL.get(_str(tier_dict.get("default_agent")) or "")
if agent:
tier_out["default_agent"] = agent
model = _str(tier_dict.get("default_model"))
Expand All @@ -213,7 +215,7 @@ def normalize_managed_config(raw: dict) -> dict:
name = _str(raw.get("name"))
if name:
result["name"] = name
default_agent = _AGENT_ENUM_TO_TOOL.get(_str(raw.get("default_agent")) or "")
default_agent = AGENT_ENUM_TO_TOOL.get(_str(raw.get("default_agent")) or "")
if default_agent:
result["default_agent"] = default_agent
enabled_agents: dict[str, dict] = {}
Expand Down
Loading
Loading