Fao golden data#2106
Open
shvngisingh wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds validation configurations and golden datasets for both the US HUD income and FAO currency statvar imports. Additionally, it updates the HUD income processing script to support downloading and processing data up to the current year, with corresponding test coverage. A review comment points out a potential resource leak in process.py where a streaming HTTP request is initiated without a context manager or explicit closure, and suggests wrapping the request in a with statement to ensure connections are safely closed.
shvngisingh
force-pushed
the
fao_golden_data
branch
from
July 21, 2026 09:02
e6908bd to
221093a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added golden to fao_currency_statvar import