Revert dual writes for spanner DB - #654
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the hardcoded Spanner table names spannerObservationTableName and spannerTimeSeriesTableName from the run_dataflow_job step in the Spanner ingestion workflow. There are no review comments, and I have no feedback to provide.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -4 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
n-h-diaz
approved these changes
Jul 17, 2026
vish-cs
changed the title
vish-cs
force-pushed
the
db
branch
2 times, most recently
from
July 27, 2026 07:41
e3103e6 to
6e277d4
Compare
SandeepTuniki
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
a) Remove dual writes to ingestion status tables (eliminate SPANNER_GRAPH_DATABASE_ID var)
b) Remove temporary ingestion tables (v3) to clean up the ingestion workflow
c) Migrate the auto-refresh pipeline to a new DB in dc-graph-staging