chore(deps): bump x/crypto, clear an x/text DoS - #136
Draft
ecv wants to merge 1 commit into
Draft
Conversation
Bumping the pinned SSH crypto library also carries the Unicode text package forward, and that is where the real exposure was: the PowerDNS client's zone fetch path reaches a normalization routine that loops forever on invalid input, so a malformed upstream response is enough to hang a reconcile. It is the only advisory the vulnerability scanner reports as reachable from this module's own code. The crypto bump itself is hygiene. Its SSH packages enter the module only through the PowerDNS integration test harness and are absent from both shipped binaries, though the pinned release is still listed as affected by an advisory covering source-address restrictions that go unenforced for non-public-key authentication callbacks. v0.55.0 rather than the newest release: v0.56.0 raises the module's Go directive to 1.26, which the release image does not yet build with, and the two further advisories it closes are unreachable from the operator. This supersedes the long-stale Dependabot bump to v0.45.0, whose two advisories were already carried in transitively and closed as fixed. Claude-Session: https://claude.ai/code/session_018tBsAgdCCzyooXjz2Dh9xp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DNS zone fetch path reaches a Unicode normalization routine that can spin forever on invalid input, so a malformed upstream response is enough to hang a reconcile, and moving the pinned crypto library forward carries the text library past that fix.
The crypto side is hygiene rather than exposure, since its SSH code enters only through the PowerDNS integration test harness and is absent from both shipped binaries.
The newest crypto release was deliberately not taken, because it raises the module's Go directive past what the release image builds with and the extra advisories it closes are unreachable here.
This supersedes the Dependabot bump that has been open since last November, whose advisories were already carried in transitively and closed as fixed months ago.
Test plan
https://claude.ai/code/session_018tBsAgdCCzyooXjz2Dh9xp