Code quality improvements: Remove unused configs and enhance syntax highlighting - #113
Merged
dborgards merged 5 commits intoNov 28, 2025
Merged
Conversation
…ighlighting - Remove unused TypeScript and ESLint configuration files (tsconfig.json, .eslintrc.json, eslint.config.mjs) as this is a pure syntax highlighting extension with no TypeScript/JavaScript code - Remove lint.yml workflow since there are no source files to lint - Remove ESLint-related devDependencies from package.json - Complete CHANGELOG.md with detailed version 0.0.1 release notes - Add numeric literal support to MarScript grammar: * Hexadecimal numbers (0x1A2B) * Binary numbers (0b1010) * Floating-point numbers (123.45, 1.23e-4) * Integer numbers with optional scientific notation These changes simplify the project structure and improve syntax highlighting capabilities.
Add explicit CodeQL workflow that documents this is a pure syntax highlighting extension with only JSON configuration files and no JavaScript/TypeScript source code to analyze. This prevents CodeQL from failing when trying to analyze non-existent JS/TS code and clearly communicates the project structure. Fixes: CodeQL error "no source code for JavaScript/TypeScript"
- Remove custom CodeQL workflow to avoid conflicts with GitHub's Default setup - Add "Project Structure" section to README documenting this is a pure syntax highlighting extension with only JSON configuration files - Add maintainer note about disabling CodeQL Default setup in repo settings - Update features list to include numeric literals support The CodeQL Default setup should be disabled in repository settings since this project contains no JavaScript/TypeScript source code to analyze.
Create a custom CodeQL workflow that explicitly handles this project's structure as a pure JSON configuration project with no source code: - Add .github/workflows/codeql.yml workflow that initializes CodeQL for javascript-typescript (as expected by GitHub) but uses a config file to exclude all paths from scanning - Add .github/codeql-config.yml that explicitly excludes all file types and only includes non-existent src/** directory - This prevents the "no source code found" error while satisfying GitHub's CodeQL requirements The workflow will run successfully but perform no actual code analysis, which is appropriate for this syntax highlighting extension.
CodeQL cannot be configured via workflow to handle a project with zero source code files. Multiple approaches were attempted: - Custom workflow with empty language matrix - Config file excluding all paths - Workflow with path exclusions All approaches failed because CodeQL's database finalization requires actual source code to exist, even if excluded from scanning. Solution: - Remove all CodeQL workflow and config files - Add detailed step-by-step instructions in README for maintainers to manually disable CodeQL Default setup in GitHub repository settings - Document why this is necessary (project previously had TS config files, triggering auto-detection) This is the only reliable solution for a pure JSON configuration project with no actual source code.
dborgards
deleted the
claude/review-code-quality-01Tu9FGnQhvMz3AWjVasrABc
branch
November 28, 2025 15:13
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as this is a pure syntax highlighting extension with no TypeScript/JavaScript code
These changes simplify the project structure and improve syntax highlighting capabilities.